Fetch and log (and cache) buy/sell quote token symbols#4396
Merged
Conversation
jmg-duarte
force-pushed
the
jmgd/quotes/symbols
branch
from
06363a9 to
bfa67f7
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements token symbol caching in the QuoteHandler using the moka library. It introduces a token_name_cache and integrates an AlloyProvider to fetch symbols for sell and buy tokens, which are then included in debug logging. No critical issues were found, and I have no feedback to provide.
MartinquaXD
reviewed
May 11, 2026
Contributor
MartinquaXD
left a comment
MartinquaXD
left a comment
There was a problem hiding this comment.
We already have a token-info crate that queries and caches symbol and decimals. Can this be used here?
tilacog
approved these changes
May 11, 2026
Contributor
tilacog
left a comment
tilacog
left a comment
There was a problem hiding this comment.
Apart from @MartinquaXD's comment, LGTM
(I was also not aware of that crate)
MartinquaXD
approved these changes
May 12, 2026
Contributor
MartinquaXD
left a comment
MartinquaXD
left a comment
There was a problem hiding this comment.
LGTM. 2 nits:
- description needs to be updates
- the log does not contain the new fields if the symbol ends up being
None. I asked on slack if this would be acceptable or if another behavior is preferred.
MartinquaXD
reviewed
May 12, 2026
Co-authored-by: Martin Magnus <martin.beckmann@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Logs quote token symbols, keeps them in a cache to avoid the network
Changes
How to test
N/A