chore: add minimal solhint config#13
Conversation
kaze-cow
left a comment
kaze-cow
left a comment
There was a problem hiding this comment.
Lots of coding standards enforcement good to see.
fedgiac
left a comment
fedgiac
left a comment
There was a problem hiding this comment.
Looks good, mostly minor comments.
Approving is blocked because there are changes belonging to PR 2 and I expect this to change once upstream PRs are merged.
|
Looks good! Can be merged once the previous PR is merged. |
anxolin
left a comment
anxolin
left a comment
There was a problem hiding this comment.
Looks mostly ok, but a few comments. The PR description says "and only adds the intentional rules", but I believe your config is not adding but replacing the rules
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
fedgiac
left a comment
fedgiac
left a comment
There was a problem hiding this comment.
Very small comments but the rest is good, approving in advance since I don't think my comment need much discussion.
Co-authored-by: Federico Giacon <58218759+fedgiac@users.noreply.github.com>
4 participants
Description
Add a small Solhint setup that uses the local Solhint dependency.
Context
The root Solhint config extends
solhint:recommendedand only adds the intentional rules. The script and test folders have small override configs for their own style.Out of Scope
This PR does not add Slither, Justfile commands, CI, or hooks.
Testing Instructions
npm install --prefix dev.dev/node_modules/.bin/solhint --max-warnings 0 'src/**/*.sol'.dev/node_modules/.bin/solhint --max-warnings 0 'script/**/*.sol'.dev/node_modules/.bin/solhint --max-warnings 0 'test/**/*.t.sol'.