Skip to content

[CLI] Audio playback error handling #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majunze2001 merged 1 commit into from
Apr 3, 2026
Merged

[CLI] Audio playback error handling #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 31 additions & 12 deletions python/cornserve/cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import json
import os
import sys
from contextlib import suppress
from contextlib import ExitStack, suppress
from pathlib import Path
from typing import Annotated, Any, Literal

Expand Down Expand Up @@ -625,30 +625,46 @@ def _handle_streaming_audio_response(
console = rich.get_console()

# Lazy import to avoid requiring audio dependencies on systems that don't need them
pcm_player_cls: Any | None = None
try:
from cornserve.cli.audio_streamer import PCMStreamPlayer # noqa: PLC0415

except (ImportError, OSError) as e:
rich.print(
Panel(
f"Error: {e}",
style="red",
f"Audio playback unavailable on this machine ({e}); continuing without playback.",
style="yellow",
expand=False,
)
)
return
else:
pcm_player_cls = PCMStreamPlayer

# If aggregation mode: accumulate values for specified keys
accumulated_data = {key: "" for key in aggregate_keys} if aggregate_keys else {}
audio_panel_shown = False

try:
with (
PCMStreamPlayer(
sample_rate=audio_sample_rate, channels=audio_channels, pcm_format=audio_pcm_format
) as player,
Live("Waiting for response...", vertical_overflow="visible") as live,
):
with ExitStack() as stack:
live = stack.enter_context(Live("Waiting for response...", vertical_overflow="visible"))
player: Any | None = None
try:
if pcm_player_cls is not None:
player = stack.enter_context(
pcm_player_cls(
sample_rate=audio_sample_rate,
channels=audio_channels,
pcm_format=audio_pcm_format,
)
)
except Exception as e:
rich.print(
Panel(
f"Audio playback unavailable on this machine ({e}); continuing without playback.",
style="yellow",
expand=False,
)
)
Comment on lines +660 to +666

@gemini-code-assist gemini-code-assist Bot Apr 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While rich.print is used throughout the file, it is generally safer to use live.console.print or the local console variable when a Live display is active. This ensures that the output is correctly synchronized with the live display and avoids potential layout issues in some terminal environments. Additionally, using the console object defined at line 625 would be more consistent with its usage at line 705.

Suggested change
rich.print(
Panel(
f"Audio playback unavailable on this machine ({e}); continuing without playback.",
style="yellow",
expand=False,
)
)
console.print(
Panel(
f"Audio playback unavailable on this machine ({e}); continuing without playback.",
style="yellow",
expand=False,
)
)


for line in response.iter_lines(chunk_size=None, decode_unicode=True):
line = line.strip()
if not line:
Expand All @@ -659,14 +675,17 @@ def _handle_streaming_audio_response(
response_data = json.loads(line)

value = _extract_nested_value(response_data, audio_key)
if value is not None:
if value is not None and player is not None:
pcm_bytes = base64.b64decode(str(value))
player.feed(pcm_bytes)

if not aggregate_keys and not audio_panel_shown:
# Since we won't be showing a table, show text instead.
live.update(Panel("Receiving audio...", style="green"))
audio_panel_shown = True
elif value is not None and not aggregate_keys and not audio_panel_shown:
live.update(Panel("Receiving audio (playback disabled)...", style="green"))
audio_panel_shown = True

if aggregate_keys:
# Extract and accumulate values for each aggregate key
Expand Down
Loading