feat!: emacs tests - #291
Open
MuntasirSZN wants to merge 25 commits into
Open
Conversation
MuntasirSZN
marked this pull request as ready for review
July 17, 2025 09:27
Owner
|
I don't have enough knowledge to review this PR. |
Collaborator
I'm a bit busy so I'll review it within a week. |
• Simplify rustowl-cursor to always issue async requests for better responsiveness; remove explicit lsp-mode/workspace guard • Rework rustowl-cursor-call to build params via plist for clarity and reduce boilerplate • Rename public autoloads to consistent rustowl-* names and update mode hooks accordingly • Make rustowl-underline robust by clamping to buffer bounds and handling reversed ranges to avoid overlay errors • Change add-hook/remove-hook usage to non-buffer-local, aligning with typical mode-level activation BREAKING CHANGE: • Function renames: • enable-rustowl-cursor -> rustowl-enable-cursor • disable-rustowl-cursor -> rustowl-disable-cursor • Hook behavior changed: post-command-hook is no longer added/removed buffer-locally from these helpers. If you relied on buffer-local hooks, pass a local arg in your own configuration or adapt your setup accordingly.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces comprehensive Emacs testing infrastructure and improvements to the RustOwl Emacs plugin. The changes add extensive ERT tests, improve code quality with better documentation and error handling, and establish CI/CD for Emacs-specific validation.
- Added comprehensive ERT test suite covering all public functions and edge cases
- Enhanced code quality with improved documentation, error handling, and function renaming for consistency
- Established CI/CD pipeline with linting, testing, and build validation for Emacs components
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/bump.sh | Added version update logic for Emacs package files (Eask and rustowl.el) during stable releases |
| rustowl.el | Enhanced with comprehensive documentation, improved error handling, function renaming for consistency, and code formatting improvements |
| emacs-tests/rustowl-test.el | New comprehensive test suite with 284 lines covering all public functions, edge cases, and error conditions |
| Eask | New Emacs package configuration file defining package metadata, dependencies, and test scripts |
| .github/workflows/emacs-checks.yml | New CI workflow for Emacs-specific linting, testing, and build validation |
…timize line calc - Make post-command hooks buffer-local to avoid global side effects - Restore LSP active/workspace check in `rustowl-cursor` - Optimize line count using `(line-number-at-pos (point-max))`
MuntasirSZN
force-pushed
the
feat/emacs
branch
from
August 10, 2025 15:03
2a2351a to
f8f5304
Compare
Collaborator
Author
|
@cordx56 its ready (besides commitlint uhh merge commits....) |
Contributor
|
🤖 Bot: PR has not seen activity in 30 days and will therefore be marked as stale. It will be closed in 7 days if no further response is found. |
MuntasirSZN
added
enhancement
cordx56
reviewed
Jun 2, 2026
Updated the script paths for building and installing Rustowl in the workflow.
avifenesh
removed their request for review
June 11, 2026 22:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.