feat(builder): aggregate validation errors in StreamBuilder (#631) - #691
Open
ZacLou wants to merge 1 commit into
Open
feat(builder): aggregate validation errors in StreamBuilder (#631)#691ZacLou wants to merge 1 commit into
ZacLou wants to merge 1 commit into
Conversation
…protocol#631) - Add ValidationError class with a frozen array - Modify all StreamBuilder setters to record issues instead of throwing immediately - Collect missing-required-fields check into the same issue list - Throw one ValidationError at build() time with every problem surfaced - Reset after each failed build so retrying a fixed builder works - Add tests covering multi-field aggregation, issue reset, and happy path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #631.
Summary
Instead of failing on the first invalid field, StreamBuilder now collects every problem and throws one
ValidationErrorwith a.issues[]array.Changes
ValidationErrorclass (src/errors.ts) with a frozenissues[]array_issuesis reset after each failedbuild()so a fixed builder can be retriedExample