feat(batch): add typed BatchPartiallySubmittedError (closes #601) - #686
Open
Ranjeet2063 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a typed
BatchPartiallySubmittedErrorcarryingfirstFailureIndex,skippedIndices, andoutcomes, allowing callers to catch and inspect mid-batch failures without manually parsing the outcomes array, and provides the{ throwOnPartial: true }option insubmitBatch(closes #601).Key Changes
src/errors.ts:BatchPartiallySubmittedErrorextendingErrorwithfirstFailureIndex,skippedIndices, andoutcomes.BatchPartiallySubmittedErrortoisConduitErrortype guard.src/batch-tx.ts:throwOnPartial?: booleantoBatchSubmitOptions.submitBatchto throwBatchPartiallySubmittedErrorwhenoptions.throwOnPartialis true and a failure occurs.BatchPartiallySubmittedError.src/index.ts:BatchPartiallySubmittedError.src/tests/batch-submit.test.ts:BatchPartiallySubmittedErrorwhenthrowOnPartialis enabled, and verified standard return behavior when omitted.Verification
vitest run src/tests/batch-submit.test.ts: 21/21 tests passing.npm run build.