feat(builder): aggregate StreamBuilder validation errors into ValidationError (closes #631) - #681
Open
Ranjeet2063 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aggregates all parameter and required-field problems encountered during stream configuration into a single
ValidationErrorcarrying a.issues[]array, instead of terminating prematurely on the first invalid setter call (closes #631).Changes
src/errors.ts:ValidationIssueinterface (field?: string,message: string).ValidationErrorclass extendingErrorwithreadonly issues: readonly ValidationIssue[]and human-friendly structured summaries.ValidationErrorinisConduitError().src/builder.ts:StreamBuildersetters store raw inputs without throwing immediately on invocation, enabling clean fluent chaining.validate(): ValidationIssue[]method for non-throwing validation inspection.build()evaluates all field rules in aggregate and throwsValidationErrorwith all detected issues in.issues[].toContractArgs()surfaces missingratePerSecondviaValidationError.src/index.ts:ValidationErrorandValidationIssue.src/tests/stream-builder-validation-aggregate.test.ts:Verification
src/tests/stream-builder-validation-aggregate.test.ts(10/10).tsc --noEmit).