test: add cleanup tests for RateTicker interval lifecycle - #518
Open
ZacLou wants to merge 3 commits into
Open
Conversation
…rSecond change Confirms the setInterval loop is properly cancelled on unmount and when ratePerSecond changes (via useEffect cleanup). Adds three new tests: - clears the interval on unmount (no stale intervals) - clears the old interval when ratePerSecond changes - reflects the new rate after ratePerSecond changes Addresses conduit-protocol#465
ZacLou
force-pushed
the
fix/rateticker-rAF-cleanup-465
branch
from
September 5, 2026 11:19
5750d46 to
87616fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #465
Context
The issue asks to confirm the update loop is cancelled on unmount and when
ratePerSecondchanges, and to add tests.The
RateTickercomponent usessetInterval(notrequestAnimationFrame) for its 100ms tick. The cleanup is already correctly handled via theuseEffectreturn function (() => clearInterval(id)), which runs both on unmount and wheneverratePerSecond,endTime, ordecimalschange.Changes
Added 3 new tests to
components/stream/__tests__/RateTicker.test.tsx:setInterval/clearInterval, unmounts the component, and asserts the interval ID was passed toclearIntervalNo production code changes — the existing cleanup is correct.