Skip to content

chore: adopt Dr. Concret.io cost and feedback improvements - #16

Open
abhinavguptas wants to merge 2 commits into
mainfrom
feature/dr-concretio-cost-feedback-b2925fc
Open

abhinavguptas wants to merge 2 commits into
mainfrom
feature/dr-concretio-cost-feedback-b2925fc

Conversation

@abhinavguptas

@abhinavguptas abhinavguptas commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Change

Pin Dr. Concret.io to the Trace-verified action b2925fc25f964faab9ee0d9a2bcf15276316f96f. Reviews update one main diagnosis, retain normal line/file discussions, and report invocation tokens and estimated cost before cache discounts. Compact requests reduce repeated source and completion text while retaining adaptive thinking and existing review budgets.

The v2 workflow uses supported inputs, explicit permissions including actions: read, per-PR publication concurrency, and an always-uploaded report artifact. No application code changes.

Validation

The action passed TypeScript checks, 114 regression tests, build verification, and target-model result/context protocol checks. Trace PR #32 pilot completed publication with 196/198 changed ranges and 4/4 cross-file checks reviewed. Two ranges remained explicitly unresolved. Its 252,509 tokens cost an estimated $0.1590 before cache discounts. This is observed usage, not a matched savings or quality benchmark.

Workflow YAML was parsed locally and the action/artifact pins verified. Repository-specific CI and this workflow's first review remain merge checks. Reviewer implementation PR.

Event and review behavior

  • Internal pull requests and maintainer-triggered reviews are supported; fork and Dependabot PRs are explicitly skipped.
  • Findings remain advisory GitHub COMMENT reviews.
  • Migration change: the previous submit_review_verdict: true setting is removed. v2 does not submit approvals or request changes.

Rollback

Revert this workflow commit to restore the prior complete workflow and inputs. A pin-only rollback is insufficient because v1 and v2 inputs differ. Previous reviewer pins:

  • v1 resolved to 7d151e668dce51de3022b95ecfab53b0a69cc5a2 at rollout preparation.

Current rollout blocker

Initial v2 run stopped during countTokens: Gemini returned HTTP 400 INVALID_ARGUMENT, “API key not valid.” No generation calls were made, and the unavailable-review main comment was delivered successfully. Replace this repository’s configured GEMINI_API_KEY with a valid authorized key, then rerun this workflow before merging. The missing optional rules-file notices are not the failure cause.

Compact cost footer

Pin the reviewer to f8abbdf3ccbe9fc2c86ac7bca524a915a2ea50af. This presentation-only change restores the compact Dr. Concret.io footer with model, total tokens and estimated cost. A small expandable breakdown replaces internal accounting in PR comments. Calculations, artifacts, provider behavior and action interfaces are unchanged.

Validation: 118 tests, type/lint checks and build passed. A local preview of the saved Trace PR #34 report preserved 298,337 tokens and $0.1874 before cache discounts. Implementation PR.

The pin-only commit uses [skip ci] to avoid a paid review solely for formatting. Required checks may remain pending; do not bypass them. The next normal code change without the skip instruction can run normal validation. No historical comments are rewritten. Inspect the next normal Trace review after this pin is adopted.

Rollback this footer update by reverting this commit or restoring b2925fc25f964faab9ee0d9a2bcf15276316f96f. Earlier v1 migration rollback instructions still apply to the complete migration.

@github-actions

Copy link
Copy Markdown

🩺 Dr. Concret.io

Diagnosis: Review unavailable. Manual review needed.

0 concerns

Reviewed commit: 60e9e77

Coverage: 0/13 changed ranges; 0/0 cross-file questions

This run: 0 known tokens · estimated $0.0000 USD before cache discounts

Findings are advisory model-reported concerns.

Workflow and report

All findings for 60e9e77 (0)

No actionable concerns reported.

Coverage limitations and delivery status for this attempt

Requested line/file comments confirmed.

  • Not scheduled

Configured rules path not found: CLAUDE.md
Configured rules path not found: AGENTS.md
Configured rules path not found: GEMINI.md
0 source exclusions/limitations; see the report artifact.

Token usage and estimated cost for this attempt

Token usage and estimated cost (this run)

Metric Value
Generation attempts, including retries 0
Total known generation tokens 0
Input tokens 0
Output tokens, including thinking 0
Thinking tokens (included above, when reported) 0
Cached input tokens (reported subset, included in input) 0
Attempts reporting cache metadata 0/0
Attempts without total usage 0
Estimated API cost $0.0000 USD

Usage totals cover 0/0 attempts; input/output covers 0/0; thinking covers 0/0. Unknown usage is excluded, not zero.

Model: gemini-2.5-flash. Rates checked 2026-09-15. Standard paid-tier text list prices; output includes thinking. Before cache discounts, free-tier allowances, credits and taxes. This invocation only; not a Google invoice.

Admission budget charged: 0 tokens; unknown-usage reservations: 0. This is a scheduling ledger, not token consumption or dollars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant