Return the built filesystem from generate_boot_image - #376
Merged
Conversation
Johan-Liebert1
enabled auto-merge
August 11, 2026 09:58
In bootc we call this function to generate the boot EROFS image, then we again perform a very expensive operation of re-creating the filesystem. `generate_boot_image` already creates a filesystem, so simply return that Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Johan-Liebert1
force-pushed
the
api-update
branch
from
August 11, 2026 10:07
f5c85ff to
68d30da
Compare
Collaborator
Author
|
Fixed a clippy warning |
giuseppe
approved these changes
Aug 11, 2026
Johan-Liebert1
added a commit
to Johan-Liebert1/composefs-rs
that referenced
this pull request
Aug 12, 2026
In composefs#376, I had forgotten that we transform the filesystem (which masks /boot) before creating the EROFS. Making off /boot is the opposite of what we need in bootc since bootc searches for boot entries in /boot Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Johan-Liebert1
added a commit
to Johan-Liebert1/composefs-rs
that referenced
this pull request
Aug 12, 2026
In composefs#376, I had forgotten that we transform the filesystem (which masks /boot) before creating the EROFS. Making off /boot is the opposite of what we need in bootc since bootc searches for boot entries in /boot Define a function `generate_boot_image_get_fs` which does the exact same operations as `generate_boot_image`, but returns the untransformed filesystem to the caller Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In bootc we call this function to generate the boot EROFS image, then we again perform a very expensive operation of re-creating the filesystem.
generate_boot_imagealready creates a filesystem, so simply return that