fix: adds config hash label as unique seeding label#81
Merged
Conversation
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a deterministic runtime-configuration hash label (_agent_config_hash) and incorporates it into evidence label sets/UUID seeding to reduce evidence-stream collisions when multiple agents fall back to the same _agent=ccf identity.
Changes:
- Add
_agent_config_hashlabel to both agent foundational labels and plugin evidence labels, computed as a SHA-256 hash over a normalized runtime configuration subset. - Seed agent-run evidence UUIDs from the full foundational label set (now including
_agent_config_hash). - Seed plugin evidence UUIDs from merged labels at submission time, and add/expand unit tests plus documentation describing the new label.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| runner/result.go | Seeds evidence UUIDs from merged labels during evidence creation. |
| cmd/agent.go | Computes _agent_config_hash, adds it to foundational/plugin labels, and uses it for agent evidence UUID seeding. |
| cmd/agent_test.go | Updates label expectations and adds tests for hash stability and UUID/label behavior. |
| README.md | Documents the new _agent_config_hash label and rationale. |
| docs/configuration.md | Documents _agent_config_hash contents and its effect on evidence streams. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to ONLY implement the extra label to evidence sent by the agent -- ONLY.