Skip to content

Add support for Zenoh transport#26

Merged
gonzalocasas merged 4 commits intomainfrom
zenoh
Apr 16, 2026
Merged

Add support for Zenoh transport#26
gonzalocasas merged 4 commits intomainfrom
zenoh

Conversation

@gonzalocasas
Copy link
Copy Markdown
Member

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@gonzalocasas
Copy link
Copy Markdown
Member Author

@chenkasirer and by extension, ping here as well ;)

Copy link
Copy Markdown
Member

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

self.remove_listener(event_key, self._local_callbacks[k])
del self._local_callbacks[k]

def advertise(self, topic):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

judging by the name, it sounds like this method has side-effects but it's just putting together an identifier? am I missing anything?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to the API being modeled after ROS' api that requires advertising before publishing. Perhaps we should make a breaking-change at some point and move away from ROS terminology on the public API level

@gonzalocasas gonzalocasas merged commit abfbab7 into main Apr 16, 2026
13 checks passed
@gonzalocasas gonzalocasas deleted the zenoh branch April 16, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants