Skip to content

Add Plone 6.2 support and tests, fix the remaining Plone 6 incompatibilities - #19

Open
chris-adam wants to merge 11 commits into
plone61from
plone61-chris-adam
Open

chris-adam wants to merge 11 commits into
plone61from
plone61-chris-adam

Conversation

@chris-adam

@chris-adam chris-adam commented Oct 11, 2026 •

Copy link
Copy Markdown

Builds on plone61: adds a Plone 6.2 buildout and CI (6.1 and 6.2), fixes the 6.1 tests broken by the native namespace (horse-with-no-namespace), and ports what was left for Plone 6: the upgrade form's log stream, portal_quickinstaller, reference_catalog, plone.app.folder and @@plone-addsite. It also adds unit tests and robot tests for the upgrade form, which first pinned the Plone 4 behaviour on master.

⚠️ resetProfiles can't re-import the Plone base profile on 6.2: Products.DateRecurringIndex 4.0.0 breaks the catalog step re-import (AttributeError: _since_field), which is a Plone core issue.
⚠️ This overlaps with #18 (native namespace, quickinstaller removal), which it doesn't include.

🤖 Generated with Claude Code

chris-adam and others added 5 commits October 11, 2026 05:20
collective.monkeypatcher 2.0.1 (Plone 6.1) still declares the
pkg_resources "collective" namespace, which hides the PEP 420
collective.upgrade: bin/test failed with "No module named
'collective.upgrade'". horse-with-no-namespace makes both work.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
test-6.2.cfg and requirements-6.2.txt from IMIO/scripts-buildout,
Makefile limited to 6.1 and 6.2 (Python 3.13), GitHub Actions tests
6.1 and 6.2, coverage on 6.2 with a .coveragerc for Coveralls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
51 unit/functional tests (one module per production module, pas.rst
doctest kept) and 4 robot scenarios for the only browser entry point,
@@collective.upgrade.form. They pin the Plone 4 behaviour: green on
Plone 4.3 (master worktree). On Plone 6.2, 7 tests and 1 scenario fail
on the code still to port (quickinstaller, reference_catalog,
plone.app.folder, @@plone-addsite, log streaming to the WSGI response,
Python 3 dict view).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Stream the upgrade log to the WSGI response as bytes (the form showed
  an empty page).
- No more portal_quickinstaller: profile versions decide what is
  installed, uninstallAddOns uses the installer view.
- fixDuplicateUIDs without reference_catalog (plone.uuid), Python 3
  sort key fix; CMFEditions folder migration and reference targets
  cleanup skip when plone.app.folder / Archetypes are missing.
- resetProfiles without @@plone-addsite; cleanupBrokenTextIndexes on
  Python 3.
- Version 2.0.0.dev0, Plone 6.2 classifier, obsolete test_suite removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coveralls-official

coveralls-official Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 38566872675

Warning

No base build found for commit 58f6acf on plone61.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 89.825%

Details

  • Patch coverage: 3 uncovered changes across 1 file (52 of 55 lines covered, 94.55%).

Uncovered Changes

File Changed Covered %
src/collective/upgrade/testing.py 19 16 84.21%
Total (4 files) 55 52 94.55%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 914
Covered Lines: 821
Line Coverage: 89.82%
Coverage Strength: 0.9 hits per line

💛 - Coveralls

chris-adam and others added 5 commits October 14, 2026 14:50
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chris-adam
chris-adam marked this pull request as ready for review October 28, 2026 09:56
@chris-adam
chris-adam requested a review from duchenean October 28, 2026 09:56
rfbrowser init fails on ubuntu 26.04 (not supported by Playwright yet).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant