Repository navigation
fix(workflow-js): generate Windows GNU LLVM bindings - #7139
Merged
Merged
Conversation
Select the existing rquickjs bindgen feature only for the Windows GNU LLVM target, which has no bundled bindings. Reuse the existing platform-specific dependency configuration. Validated on x86_64-pc-windows-gnullvm with Rust 1.98.1 and isolated libclang 18.1.1: default library check passed; existing VM integration tests: 83 passed, 0 failed. Removing the cfg reproduces the missing-target-bindings build failure. ARM64 execution and cross-host builds remain unverified. Signed-off-by: Codex <codex@openai.com>
github-actions
Bot
added
the
contribution-gate
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the Windows GNU LLVM–specific binding-generation change.
No open issues 🎉
What changed in this PR
Fixes the workflow-js build on Windows GNU LLVM targets by generating rquickjs bindings instead of relying on missing bundled bindings.
Changes:
- Enables
rquickjs’s existingbindgenfeature specifically for Windows GNU LLVM targets. - Leaves other target selections, dependency versions, and the lockfile unchanged.
| File | Description |
|---|---|
crates/workflow-js/Cargo.toml |
Adds a target-specific dependency entry enabling binding generation for Windows GNU LLVM. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No-Issue: Fixes the missing bundled bindings for the Windows GNU LLVM target; no matching tracked issue was found.
The default workflow-js build on
x86_64-pc-windows-gnullvmtries to include a bundled rquickjs-sys binding file that is absent from the locked crate. Enable the existingbindgenfeature in a target-specific dependency, following the existing platform configuration pattern. Other Windows target environments keep their existing selection. This is a standalone three-line manifest change with no dependency-version or lockfile changes.Validation on base
4d600eaaewith Rust 1.98.1, native x64 Windows GNU LLVM and libclang 18.1.1:ARM64 execution, cross-host sysroots and other libclang configurations remain unverified. CI qualification, full application integration and release acceptance are separate.
Merge qualification, November 2, 2026 UTC: the earlier baseline CI failures are resolved in the current branch. At
74f24fc50446ce615d036d6d651c8b2a38615845, all three required contexts pass: Lint, Test (windows-latest), and npm wrapper smoke (ubuntu-latest). Current original-PR CI run. The Ubuntu test job remains in progress; no completed job has failed.Independent retained macOS cross compilation passed for the unchanged workflow-js sources and manifest on x86_64-pc-windows-gnullvm, with a COFF-x86-64 QuickJS object. Removing only this target cfg reproduced the missing bundled-binding error. All 124 selected registry versions/checksums still match the current PR lock. This is cross-compilation evidence, not independent native Windows execution; the 83 native checks above remain contributor-reported. Integrated application, supported-OS and package release qualification remain open.