refac(gcp): drop the pre-multi-DC environment mirrors - #658
Open
NJona wants to merge 1 commit into
Open
Conversation
NJona
force-pushed
the
multi-dc-11-drop-legacy-env-mirror
branch
from
August 10, 2026 14:16
46a15e1 to
b1f5fb3
Compare
NJona
force-pushed
the
multi-dc-11-drop-legacy-env-mirror
branch
from
August 10, 2026 15:47
5b3f214 to
a843543
Compare
NJona
force-pushed
the
multi-dc-11-drop-legacy-env-mirror
branch
2 times, most recently
from
August 12, 2026 09:49
8ad6a81 to
c308bea
Compare
NJona
force-pushed
the
multi-dc-11-drop-legacy-env-mirror
branch
from
August 13, 2026 12:48
c308bea to
e40263e
Compare
NJona
force-pushed
the
multi-dc-11-drop-legacy-env-mirror
branch
from
August 14, 2026 07:01
aa5765b to
6a96deb
Compare
The migration to DataCenters is complete: no step reads the top-level ControlPlaneNodes, CephNodes, GatewayIP, PublicGatewayIP or SshProxyIP fields of CodesphereEnvironment any more. So mirrorPrimaryDataCenter has nothing left to serve and goes away, along with the eight call sites that kept it up to date. The fields themselves stay, read-only: ensureDataCenters still adopts them into the primary data center, which is what makes an infra file written by an OMS from before multi-DC support usable for cleanup and restart-vms. They are no longer written, so a fresh infra file describes its data centers only under "datacenters" — omitempty keeps the obsolete keys out of it instead of writing them empty. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Jona Neef <Jona.Neef.97@gmail.com>
NJona
force-pushed
the
multi-dc-11-drop-legacy-env-mirror
branch
from
August 14, 2026 07:15
6a96deb to
4bd7326
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration to DataCenters is complete: no step reads the top-level
ControlPlaneNodes, CephNodes, GatewayIP, PublicGatewayIP or SshProxyIP
fields of CodesphereEnvironment any more. So mirrorPrimaryDataCenter has
nothing left to serve and goes away, along with the eight call sites that
kept it up to date.
The fields themselves stay, read-only: ensureDataCenters still adopts
them into the primary data center, which is what makes an infra file
written by an OMS from before multi-DC support usable for cleanup and
restart-vms. They are no longer written, so a fresh infra file describes
its data centers only under "datacenters" — omitempty keeps the obsolete
keys out of it instead of writing them empty.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Signed-off-by: Jona Neef Jona.Neef.97@gmail.com