Skip to content

Implement method for finding current weather by zipcode#28

Open
Gilmoursa wants to merge 6 commits intocoderhs:masterfrom
Gilmoursa:master
Open

Implement method for finding current weather by zipcode#28
Gilmoursa wants to merge 6 commits intocoderhs:masterfrom
Gilmoursa:master

Conversation

@Gilmoursa
Copy link
Copy Markdown

Create method for finding current weather by zipcode.

api.rb

#Zip format : 33704,US
#Usage: OpenWeather::Current.zip('33704,Us')
    def zip(zip, options ={})
      new(options.merge(zip: zip)).retrieve
    end

@manusajith
Copy link
Copy Markdown

@Gilmoursa can you have a look at why the spec is failing.

@Gilmoursa
Copy link
Copy Markdown
Author

I didn't write a spec for the zip method. I'm not sure why the spec is failing in Travis CI. I ran bundle exec rspec in terminal and I have 39 tests passing and 0 failures.

@vanboom
Copy link
Copy Markdown

vanboom commented Nov 21, 2016

👍

@valerybugakov
Copy link
Copy Markdown

@manusajith is there a way to help with merge of this PR? Would love to have zipcode method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants