Integrate @codama/spec@1.7.0#1013
Draft
lorisleiva wants to merge 1 commit into
Draft
Conversation
Integrates `@codama/spec@1.7.0-rc.0` into the TS codegen pipeline and regenerates `@codama/node-types`, `@codama/nodes`, and `@codama/visitors-core` with the new presentation layer (display nodes, provide/inject, account-field selector). Held against `main` for CI and review but not merged until the spec stabilises at `1.7.0` — letting us bump to later RCs here as the spec evolves. No changeset is included for the same reason. Key changes: - `anyNode` TypeExpr: both `typeExpr.ts` fragments render it as the top-level `Node` type; the visitor generator visits-and-asserts it against `REGISTERED_NODE_KINDS`. - Config maps (`CATEGORY_DIRECTORIES`, `GENERIC_PARAM_ORDER`, walk-order maps, `NODE_CONFIGS`) absorb the new `display`/`provides` attributes; a `paramName`-only `AttributeOverride` variant renames `providedNode.node` so it doesn't shadow the visitor's `node` parameter. - Input-type generator now widens every `stringIdentifier()` attribute to `string` (not just `name`). - Visitor fixes: `getByteSizeVisitor`/`getMaxByteSizeVisitor` add `visitStringType => null` now that `stringTypeNode` is no longer a leaf; `getDebugStringVisitor` drops the trailing `()` for childless nodes; `dynamic-codecs` adds `visitInjectedValue` that throws (injected values must be resolved before codec time). - Tests: 11 new per-node fixtures for the new spec kinds, plus `anyNode` unit tests. Lint, build, and test pass across all 17 packages.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates
@codama/spec@1.7.0-rc.0into the TS codegen pipeline and regenerates@codama/node-types,@codama/nodes, and@codama/visitors-corewith the new presentation layer (display nodes, provide/inject, account-field selector).Held against
mainfor CI and review but not merged until the spec stabilises at1.7.0— letting us bump to later RCs here as the spec evolves. No changeset is included for the same reason.Key changes:
anyNodeTypeExpr: bothtypeExpr.tsfragments render it as the top-levelNodetype; the visitor generator visits-and-asserts it againstREGISTERED_NODE_KINDS.CATEGORY_DIRECTORIES,GENERIC_PARAM_ORDER, walk-order maps,NODE_CONFIGS) absorb the newdisplay/providesattributes; aparamName-onlyAttributeOverridevariant renamesprovidedNode.nodeso it doesn't shadow the visitor'snodeparameter.stringIdentifier()attribute tostring(not justname).getByteSizeVisitor/getMaxByteSizeVisitoraddvisitStringType => nullnow thatstringTypeNodeis no longer a leaf;getDebugStringVisitordrops the trailing()for childless nodes;dynamic-codecsaddsvisitInjectedValuethat throws (injected values must be resolved before codec time).anyNodeunit tests.Lint, build, and test pass across all 17 packages.