feat(dynamic-client): types generation split#1002
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: a5e65d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rogaldh
reviewed
May 28, 2026
mikhd
force-pushed
the
feat/pr3-typesgen-split
branch
from
378a1bb to
f696e45
Compare
Contributor
Author
|
Rebased onto main. |
lorisleiva
approved these changes
Jun 5, 2026
lorisleiva
left a comment
lorisleiva
left a comment
Member
There was a problem hiding this comment.
Thanks! I trust you on these dynamic clients. 🫡
mikhd
force-pushed
the
feat/pr3-typesgen-split
branch
from
f696e45 to
362549f
Compare
Contributor
Author
|
Rebased branch. |
* feat(dynamic-address-resolution): extract type generation * feat(dynamic-instructions): extract type generation * feat(dynamic-client): adjust type generation * feat: refactor generateTypesFromFile * chore: add tests * fix: cleanup * fix: improve codegen * chore: add minimum tests * fix: rebasing issues * fix(dynamic-instructions): types generation in readme * fix: remove generateInstructionBuildersMap from public api * fix: refactor codegen helpers - Add getResolutionRefs (DAR) with hasRequiredArgs/hasRequiredRemainingAccounts so dynamic-client stops re-deriving args optionality. - Extract collectEitherSignerNames (DI) and rename DAR's instruction-types files to generate-resolution-input-types / get-resolution-refs. - Emit a local non-exported ResolverFn declaration inside generated files. - Pre-compute PDA seed entries to remove the duplicate variableSeeds filter. - README update * chore: add comments * fix: tighten accounts ref - keep widened ref with withData suffix * fix: redundant nullish operator * fix: add space to unknown comments
mikhd
force-pushed
the
feat/pr3-typesgen-split
branch
from
362549f to
a5e65d3
Compare
Contributor
Author
|
Rebased again. |
This was referenced Jun 18, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR [3] splits types generation between
dynamic-instructions,dynamic-address-resolution,dynamic-client. Each package now owns the types for the concepts it implements,dynamic-clientcomposes them.Change
/codegenpath.@codama/dynamic-address-resolution/codegen— Address input types${Name}Args/Accounts/Resolvers(the resolution input contracts), types helpers, sharedgenerateTypesFromFileIO helper (keep it here for now, known inconsistency).@codama/dynamic-instructions/codegen—${Name}Signersaliases +${Program}InstructionBuildersmap.@codama/dynamic-clientbecomes a composer that reuses those primitives and emits the program-level ${Program}Methods / ${Program}Client shapes.Commands:
dynamic-address-resolution:
dynamic-instructions:
dynamic-client:
Unchanged.