Skip to content

fix(ci): use pull_request_target for fork PR welcome comments #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cobusgreyling merged 1 commit into from
Jul 4, 2026
Merged

fix(ci): use pull_request_target for fork PR welcome comments #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/welcome-contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: Welcome contributors

# pull_request_target runs in the base-repo context so fork PRs can receive
# maintainer welcome comments (GITHUB_TOKEN is read-only on pull_request).
on:
pull_request:
types: [opened]
pull_request_target:
types: [opened, synchronize]
paths:
- 'stories/**'
- 'docs/adopters.md'
Expand All @@ -11,7 +13,7 @@ on:

permissions:
issues: write
pull-requests: write
pull-requests: read

jobs:
welcome:
Expand Down Expand Up @@ -40,6 +42,16 @@ jobs:
else if (isExample) kind = 'a tool example';
else if (isDocs) kind = 'a docs improvement';

const marker = '— loop-engineering maintainers';
const comments = await github.paginate(
github.rest.issues.listComments,
{ owner: context.repo.owner, repo: context.repo.repo, issue_number: pr.number, per_page: 100 }
);
if (comments.some((c) => c.body?.includes(marker))) {
core.info('Welcome comment already present; skipping.');
return;
}

const body = [
`Thanks @${opener} for contributing ${kind} — visible, reviewable PRs like this grow the reference for everyone.`,
'',
Expand All @@ -51,7 +63,7 @@ jobs:
'- [Contributor quickstart + open issues](https://github.com/cobusgreyling/loop-engineering/discussions/123)',
'- [Good first issue backlog](https://github.com/cobusgreyling/loop-engineering/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)',
'',
'— loop-engineering maintainers'
marker
].join('\n');

await github.rest.issues.createComment({
Expand Down