Add istio gateway template#183
Open
Yoann Ciabaud (yciabaud) wants to merge 4 commits into
Open
Conversation
Member
|
Yoann Ciabaud (@yciabaud) awesome. |
Yoann Ciabaud (yciabaud)
force-pushed
the
feature-monochart-gateway
branch
from
9eb582b to
6338fb8
Compare
Yoann Ciabaud (yciabaud)
force-pushed
the
feature-monochart-gateway
branch
from
c936e35 to
0cd7ca4
Compare
Yoann Ciabaud (yciabaud)
force-pushed
the
feature-monochart-gateway
branch
from
0cd7ca4 to
b6bd15e
Compare
Author
|
Sorry I forgot to come back here for a while, I have updated my PR, feel free to have a look at it. |
| # - domain.com | ||
|
|
||
| # Istio gateway | ||
| istio_gateways: |
There was a problem hiding this comment.
Should we add [] since the list is commented out?
Suggested change
| istio_gateways: | |
| istio_gateways: [] |
There was a problem hiding this comment.
| labels: {} | ||
|
|
||
| istio_gateways: | ||
| - name: gateway1 |
There was a problem hiding this comment.
Yoann Ciabaud (@yciabaud) I think we should change the pattern now istio_gateways defined
istio_gateways:
gateway1:
enabled: true
selector:
istio: istio-gateway
servers:
- hosts:
- '*.domain.com'
port:
name: http
number: 80
protocol: HTTP
tls:
httpsRedirect: true
- hosts:
- '*.domain.com'
port:
name: http-tls
number: 443
protocol: HTTP
tls:
mode: SIMPLE
privateKey: /etc/istio/ingressgateway-certs/tls.key
serverCertificate: /etc/istio/ingressgateway-certs/tls.crt
Igor Rodionov (goruha)
requested changes
Apr 19, 2019
Member
Igor Rodionov (goruha)
left a comment
Igor Rodionov (goruha)
left a comment
There was a problem hiding this comment.
check the comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there I made a little addition to your project, I made a PR from it it you are interested in it too.
This adds the ability to create a istio gateway crd to expose istio services in an ingress gateway.