[wrangler] Condense repeated environment config warnings#13848
Open
[wrangler] Condense repeated environment config warnings#13848
Conversation
🦋 Changeset detectedLatest commit: 257f677 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
NuroDev
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
|
✅ All changesets look good |
Contributor
|
Everything looks correct. The changes are well-structured and all tests pass. Let me do a final summary of the review: Summary of changes:
The logic is correct, tests pass, and there are no issues I can identify. The changeset is properly scoped to LGTM |
penalosa
approved these changes
May 7, 2026
|
|
||
| - "env.staging" environment configuration | ||
| - The following vars exist at the top level, but not on "env.staging.vars". | ||
| This is not what you probably want, since "vars" configuration is not inherited by environments. |
Contributor
There was a problem hiding this comment.
"This is probably not what you want" is maybe a bit more idiomatic?
| ); | ||
|
|
||
| experimental(diagnostics, rawEnv, "unsafe"); | ||
| if (topLevelEnv === undefined || rawConfig?.unsafe === undefined) { |
workers-devprod
approved these changes
May 7, 2026
Contributor
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Condense repeated Wrangler environment configuration warnings.
This updates config validation so repeated missing
varsanddefineentries are summarised in one warning with a list of missing keys. It also avoids emitting the experimentalunsafewarning twice whenunsafeappears at both the top level and in the active environment.A picture of a cute animal (not mandatory, but encouraged)