Enable require-description-when-disabling lint rule on the vitest-pool-workers package

[dario-piotrowicz]

This PR enables the require-description-when-disabling lint rule on the vitest-pool-workers package.

This is a followup PR for #13698, #13703, #13710, #13741, #13803, #13804 and #13819.

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because: internal linting change
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: internal linting change

A picture of a cute animal (not mandatory, but encouraged)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5aca5ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ask-bonk]

Only line 111 has the actual empty destructuring pattern {} that triggers the lint rule. The others are default parameter values = {} which don't trigger no-empty-pattern. Good.

All changes look correct and well-reasoned. Summary of my review:

1. .oxlintrc.jsonc: Removes vitest-pool-workers from the override that disables require-description-when-disabling. Correct.
2. vitest-v3-to-v4.ts: Adds reason to no-explicit-any disable. Reason is accurate.
3. worker/index.ts: Adds reason to no-unsafe-function-type disable. Accurate — V8's Error.captureStackTrace API needs Function.
4. patch-ctx.ts: Replaces as any with as unknown as { Cloudflare: Cloudflare } typed cast, removing the lint disable entirely. The runtime Cloudflare global has compatibilityFlags at runtime; this should type-check correctly against the @cloudflare/workers-types/experimental types used in the worker tsconfig.
5. types-ambient.d.ts: Replaces Function return types with (...args: unknown[]) => unknown (removing lint disables) and adds reason to consistent-type-imports disable. Sound change.
6. test/helpers.ts: Moves file-level no-empty-pattern disable to inline with reason, and adds reason to jest/expect-expect, jest/no-disabled-tests disable.
7. cloudflare-test.d.ts: Removes file-level no-explicit-any disable, replaces any with unknown where safe, keeps any on createPagesEventContext with excellent explanation about variance.

No actionable issues found.

LGTM

github run

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13844

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13844

miniflare

npm i https://pkg.pr.new/miniflare@13844

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13844

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13844

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13844

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13844

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13844

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13844

wrangler

npm i https://pkg.pr.new/wrangler@13844

commit: 5aca5ec

[workers-devprod]

Codeowners approval required for this PR:

• ✅ @cloudflare/wrangler

Show detailed file reviewers

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

[workers-devprod]

Codeowners reviews satisfied