Skip to content

[wrangler] Preserve placement on versions secret commands#13843

Open
nzws wants to merge 1 commit intocloudflare:mainfrom
nzws:fix/wrangler-version-secrets-placement-bug
Open

[wrangler] Preserve placement on versions secret commands#13843
nzws wants to merge 1 commit intocloudflare:mainfrom
nzws:fix/wrangler-version-secrets-placement-bug

Conversation

@nzws
Copy link
Copy Markdown

@nzws nzws commented May 7, 2026

Fixes #13842.

When creating a new version via wrangler versions secret, the previous code only re-emitted a bare { mode: "smart" } placement when the API reported placement_mode === "smart", dropping any other placement entirely. The new version is now created with the placement settings returned by the API, so placement settings survive a secret put/delete/bulk round-trip.

For context, I checked the actual response from /accounts/<account_id>/workers/scripts/<worker_name>/versions/<version_id> and confirmed that the API currently returns the placement settings as expected:

$ curl https://api.cloudflare.com/client/v4/accounts/<account_id>/workers/scripts/<worker_name>/versions/<version_id> \
    -H "Authorization: Bearer $CLOUDFLARE_API_TOKEN"
{
  "result": {
    "id": "redacted",
    "number": 11,
    "metadata": {
      "created_on": "2026-05-07T04:52:34.499684Z",
      "source": "dash",
      "author_id": "redacted",
      "author_email": "redacted",
      "has_preview": true
    },
    "annotations": {
      "workers/triggered_by": "version_upload"
    },
    "resources": {
      "script": {
        "etag": "e594a213def980a2febcac3bc35c2b627b7a22ac1264ccd5c6b05533f233e160",
        "handlers": [
          "fetch"
        ],
        "placement_mode": "targeted",
        "placement": {
          "mode": "targeted",
          "target": [
            {
              "id": 12,
              "region": "aws:ap-northeast-1",
              "type": "region"
            }
          ]
        },
        "last_deployed_from": "dash"
      },
      "script_runtime": {
        "compatibility_date": "2026-05-07",
        "compatibility_flags": [
          "nodejs_compat"
        ],
        "usage_model": "standard"
      },
      "bindings": [
        {
          "name": "test",
          "type": "secret_text"
        }
      ]
    }
  },
  "success": true,
  "errors": [],
  "messages": []
}

For reference, here are the response objects observed for each placement setting:

#  Placement: Smart

        "placement_mode": "smart",
        "placement": {
          "mode": "smart"
        },

# Placement: Region

        "placement_mode": "targeted",
        "placement": {
          "mode": "targeted",
          "target": [
            {
              "id": 12,
              "region": "aws:ap-northeast-1",
              "type": "region"
            }
          ]
        },

# Placement: Service

        "placement_mode": "targeted",
        "placement": {
          "mode": "targeted",
          "target": [
            {
              "hostname": "example.com",
              "id": 410,
              "type": "http"
            }
          ]
        },

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: This is a bug fix of wrangler.

A picture of a cute animal (not mandatory, but encouraged)

image

@nzws nzws requested a review from workers-devprod as a code owner May 7, 2026 07:06
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

🦋 Changeset detected

Latest commit: e768365

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod requested review from a team and petebacondarwin and removed request for a team May 7, 2026 07:07
@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • .changeset/fix-versions-secrets-placement.md: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/secrets/bulk.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/secrets/delete.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/secrets/put.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/versions/secrets/index.ts: [@cloudflare/wrangler]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrangler versions secret commands do not properly inherit the new Placement Hints

2 participants