fix(vitest-pool-workers): filter benign "WebSocket peer disconnected" workerd noise#13833
Open
thegeekasteroid wants to merge 1 commit intocloudflare:mainfrom
Conversation
Adds the message to the existing ignoreMessages list alongside the other "disconnected:" entries. Surfaced during normal WebSocket teardown on recent workerd versions; not user-actionable.
🦋 Changeset detectedLatest commit: 9ee51db The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
petebacondarwin
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds
"disconnected: WebSocket peer disconnected"to the existingignoreMessagesfilter inpackages/vitest-pool-workers/src/pool/index.ts, alongside the other benigndisconnected:entries that are already filtered out.Why
The pool already filters several benign workerd stderr messages that fire during normal teardown —
disconnected: operation canceled,disconnected: worker_do_not_log; ...,disconnected: WebSocket was aborted. On recent workerd versions, tests that exercise the WebSocket API (including normal lifecycle teardown of WebSocket-using Workers) also surfaceworkerd/api/web-socket.c++:NNN: disconnected: WebSocket peer disconnectedwarnings. They are not user-actionable — tests pass, behavior is correct — and they obscure real regressions in CI logs.In a real workspace running ~270 tests against an
apps/apiWorker, the message reproduces ~18 times per run during normal teardown. The fix is a one-line addition to the sameignoreMessagesarray.How verified
Applied the same one-line change as a local pnpm patch against
@cloudflare/vitest-pool-workers@0.16.0; reran the full test suite — all tests still pass and the targeted stderr lines are now absent. No other warnings or errors are suppressed (the filter is an exactmessage.includes(...)substring match, identical in shape to the other entries).Changeset
.changeset/filter-websocket-peer-disconnected.md—@cloudflare/vitest-pool-workers: patch.