fix(wrangler): hide multi-env warning when env is set via CLOUDFLARE_ENV by greyvugrin · Pull Request #13827 · cloudflare/workers-sdk

greyvugrin · 2026-05-05T23:58:05Z

Changes:

Updated tests for wrangler commands to account for this use case (env specified through CLOUDFLARE_ENV)
Added fix that leverages computed targetEnvironment
Updated warning message to mention CLOUDFLARE_ENV
Updated tests to use a helper for the warning message text to check against

Example of failures prior to adjusting the source code:

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: this updates behavior to match existing docs

sierra-nicole-narvaeth-aM7r5lqKhiY-unsplash

Photo by Sierra NiCole Narvaeth on Unsplash

…v warning

…env warning message

…nstead of duplicating conditions

changeset-bot · 2026-05-05T23:58:08Z

🦋 Changeset detected

Latest commit: 4dd4a0b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

workers-devprod · 2026-05-06T00:03:34Z

Codeowners approval required for this PR:

@cloudflare/wrangler

Show detailed file reviewers

.changeset/mighty-planes-give.md: [@cloudflare/wrangler]
packages/workers-utils/src/config/config-helpers.ts: [@cloudflare/wrangler]
packages/workers-utils/src/index.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/deploy/environments.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/secret.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/versions/secrets/bulk.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/versions/secrets/delete.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/versions/secrets/put.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/versions/versions.deploy.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/versions/versions.upload.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/core/register-yargs-command.ts: [@cloudflare/wrangler]

petebacondarwin · 2026-05-06T06:00:41Z

-						const availableEnvs = Object.keys(rawConfig.env ?? {});
-						if (availableEnvs.length > 0) {
+					// The targetEnvironment will contain the resolved result of the env flag and the env var, if passed
+					if (config.targetEnvironment === undefined) {


Is this quite right?

If we are processing a redirected config, then this value is the one environment used when generating the redirected config. It's purpose is so that we can ensure that any --env or CLOUDFLARE_ENV (i.e. the current selected environment) matches the original target.

So this code might work where there is no redirected config, which I think is the case for all the tests above. But will fail otherwise...

Ah gotcha, yep I see the issue. Added a test to cover that case (it failed) and then updated the code to fix it.
Added a helper to detect if it's a redirected config to not duplicate the logic there.

Also, added tests for the expected --env="" behavior to ensure that's preserved moving forward.

pkg-pr-new · 2026-05-06T06:13:33Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13827

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13827

miniflare

npm i https://pkg.pr.new/miniflare@13827

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13827

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13827

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13827

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13827

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13827

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13827

wrangler

npm i https://pkg.pr.new/wrangler@13827

commit: 4dd4a0b

…d multi-env warning message" This reverts commit 74fe39f.

…v warning

…env warning message

…nstead of duplicating conditions

…d multi-env warning message" This reverts commit 74fe39f.

…m:greyvugrin/workers-sdk into fix-workers-deploy-warning-cloudflare-env

petebacondarwin · 2026-05-10T07:20:31Z

+					if (
+						!isRedirectedConfig(config) &&
+						config.targetEnvironment === undefined
+					) {


I'm still not sure this is the right approach.

It is possible for a redirected config to contain multiple environments. This is not really correct - we encourage these configs to be flat - but possible.

I feel like we should not be relying upon this targetEnvironment for this check. It is designed to be used to check whether the selected environment (via --env or CLOUDFLARE_ENV) is the one that the redirected config had flattened to.

greyvugrin added 6 commits May 5, 2026 15:37

[wrangler] Add tests to capture env warnings when CLOUDFLARE_ENV is set

1c232c5

[wrangler] Pull CLOUDFLARE_ENV when considering whether to display en…

28d47a9

…v warning

[wrangler] Update tests to use a helper to return the expected multi-…

74fe39f

…env warning message

[wrangler] Update warning message to mention CLOUDFLARE_ENV option

dbff650

[wrangler] Update warning behaivor to pull from existing validation i…

030e101

…nstead of duplicating conditions

Added changeset to cover changes

7d611c8

Merge branch 'main' into fix-workers-deploy-warning-cloudflare-env

fdbfad3

greyvugrin marked this pull request as ready for review May 6, 2026 00:03

greyvugrin requested a review from workers-devprod as a code owner May 6, 2026 00:03

workers-devprod requested review from a team and edmundhung and removed request for a team May 6, 2026 00:03

This comment was marked as resolved.

Sign in to view

[wrangler] Update check to consider truthy values - PR feedback

50ee612

petebacondarwin requested changes May 6, 2026

View reviewed changes

github-project-automation Bot moved this to Untriaged in workers-sdk May 6, 2026

workers-devprod added this to workers-sdk May 6, 2026

github-project-automation Bot moved this from Untriaged to In Review in workers-sdk May 6, 2026

greyvugrin added 7 commits May 6, 2026 11:15

Revert "[wrangler] Update tests to use a helper to return the expecte…

c4a62ff

…d multi-env warning message" This reverts commit 74fe39f.

[wrangler] Update wording of test snapshots

0f61edd

[wrangler] Cover redirectedConfig scenario

513fede

[wrangler] Update yargs logic to factor in redirected config use case

9158a29

[wrangler] Add tests for blank env - --env=""

3e0c096

Merge branch 'main' into fix-workers-deploy-warning-cloudflare-env

76d7492

[wrangler] Add missing export for isRedirectedConfig

3ae1d5e

greyvugrin requested a review from petebacondarwin May 7, 2026 17:52

[wrangler] Add tests to capture env warnings when CLOUDFLARE_ENV is set

27b41fb

greyvugrin added 12 commits May 7, 2026 20:12

[wrangler] Pull CLOUDFLARE_ENV when considering whether to display en…

8e2ffbd

…v warning

[wrangler] Update tests to use a helper to return the expected multi-…

5db9d5d

…env warning message

[wrangler] Update warning message to mention CLOUDFLARE_ENV option

82a978b

[wrangler] Update warning behaivor to pull from existing validation i…

0d9a362

…nstead of duplicating conditions

Added changeset to cover changes

de6e9df

[wrangler] Update check to consider truthy values - PR feedback

6818ec5

Revert "[wrangler] Update tests to use a helper to return the expecte…

0081a89

…d multi-env warning message" This reverts commit 74fe39f.

[wrangler] Update wording of test snapshots

b35c918

[wrangler] Cover redirectedConfig scenario

f1e5973

[wrangler] Update yargs logic to factor in redirected config use case

8c305ab

[wrangler] Add tests for blank env - --env=""

6050bd1

[wrangler] Add missing export for isRedirectedConfig

26e6134

petebacondarwin force-pushed the fix-workers-deploy-warning-cloudflare-env branch from 3ae1d5e to 26e6134 Compare May 7, 2026 19:12

greyvugrin added 2 commits May 8, 2026 09:42

[wrangler] Fixed CI formatting issues

0f9e233

Merge branch 'fix-workers-deploy-warning-cloudflare-env' of github.co…

4dd4a0b

…m:greyvugrin/workers-sdk into fix-workers-deploy-warning-cloudflare-env

petebacondarwin requested changes May 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(wrangler): hide multi-env warning when env is set via CLOUDFLARE_ENV#13827

fix(wrangler): hide multi-env warning when env is set via CLOUDFLARE_ENV#13827
greyvugrin wants to merge 30 commits intocloudflare:mainfrom
greyvugrin:fix-workers-deploy-warning-cloudflare-env

greyvugrin commented May 5, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented May 5, 2026 •

edited

Loading

Uh oh!

workers-devprod commented May 6, 2026 •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petebacondarwin May 6, 2026

Uh oh!

greyvugrin May 7, 2026

Uh oh!

pkg-pr-new Bot commented May 6, 2026 •

edited

Loading

Uh oh!

petebacondarwin May 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

greyvugrin commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Uh oh!

changeset-bot Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

workers-devprod commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petebacondarwin May 6, 2026

Choose a reason for hiding this comment

Uh oh!

greyvugrin May 7, 2026

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petebacondarwin May 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

greyvugrin commented May 5, 2026 •

edited

Loading

changeset-bot Bot commented May 5, 2026 •

edited

Loading

workers-devprod commented May 6, 2026 •

edited

Loading

pkg-pr-new Bot commented May 6, 2026 •

edited

Loading