fix(zero_trust_access_group): unwrap single-element list attrs to scalars - #321
Merged
Conversation
…lars (#302) In v4, azure.id, gsuite.email, and okta.name are lists. In v5, these are scalar strings (azure_ad.id, gsuite.email, okta.name). The migrator was preserving the list wrapper, producing id = [value] instead of id = value, causing 'string required, but have tuple' errors on apply. Add unwrapSingleElementList helper and call it in expandAzure, expandGsuite, and expandOkta. Handles both literal values and variable references (e.g. each.value). No-ops when the attribute is already a scalar. Fixes: #302
ssicard
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In v4,
azure.id,gsuite.email, andokta.nameare lists. In v5, these are scalar strings (azure_ad.id,gsuite.email,okta.name). The migrator was preserving the list wrapper, producingid = [value]instead ofid = value, causingstring required, but have tupleerrors onterraform apply.Fix
Add
unwrapSingleElementListhelper that converts single-element list attributes to scalar values during migration. Called fromexpandAzure,expandGsuite, andexpandOkta. Handles:id = ["group-id"]->id = "group-id"id = [each.value]->id = each.valueTests
Fixes #302