Change kubectl exec to launch in new shell window instead of suspending TUI - #21
Merged
Merged
Conversation
Pressing 'x' now launches kubectl exec in the default system terminal emulator (gnome-terminal, xterm, etc.) as a separate floating window, keeping the TUI alive so the user can type freely without losing context. https://claude.ai/code/session_01U4tvdcoQpWc17WQT3agZxh
Remove the kubectl exec pre-load so pressing 'x' simply launches the default system terminal emulator (gnome-terminal, xterm, etc.) with a plain interactive shell where the user can type any command freely. https://claude.ai/code/session_01U4tvdcoQpWc17WQT3agZxh
- Config field: Exec → Terminal, yaml tag exec → terminal, default x → T - KeyMap: Exec → Terminal binding with help text "terminal" - Case handler: "x" → m.config.Keybindings.Terminal, calls openTerminal() - Footer hints: [x]exec → [T]erminal in both normal and filtered views - Removed dead code: makeKubectlExecCmd, execWithContainer, container-exec selector case, ExecRequestMsg (none were reachable after the rework) - README: updated keybinding table and config example https://claude.ai/code/session_01U4tvdcoQpWc17WQT3agZxh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modified the
execIntoPod()function to launch kubectl exec in a new shell window rather than suspending the TUI. This allows the TUI to remain responsive while the user interacts with the exec session.Key Changes
tea.ExecProcess()call (which suspends the TUI) with a direct call tolaunchInNewShell()nilImplementation Details
The change shifts from the Bubble Tea framework's
ExecProcessmechanism (which pauses the TUI) to launching the kubectl exec command in a separate shell window vialaunchInNewShell(). This provides a better user experience by keeping the TUI active and responsive while the user operates in the kubectl exec session.https://claude.ai/code/session_01U4tvdcoQpWc17WQT3agZxh