Repository navigation
fix(nui-core): forward horizontal mouse wheel to CEF - #4360
Open
BigSmoKe07 wants to merge 1 commit into
Open
BigSmoKe07 wants to merge 1 commit into
BigSmoKe07 wants to merge 1 commit into
Conversation
Signed-off-by: Guru Saran <gurusarank@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Make horizontal scrolling work in NUI. The horizontal wheel (tilt/thumb wheel) and horizontal trackpad gestures currently do nothing on NUI pages.
How is this PR achieving the goal
CefInput.cpponly forwardedWM_MOUSEWHEELto CEF, soWM_MOUSEHWHEELnever reached the browser.WM_MOUSEHWHEELnow takes the sameSendMouseWheelEventNativepath asWM_MOUSEWHEEL. CEF builds the event withui::MouseWheelEventfrom the native message, which already mapsWM_MOUSEHWHEELto a horizontal wheel event.This PR applies to the following area(s)
FiveM, RedM
Successfully tested on
Game builds: b3889
Platforms: Windows
Checklist
Fixes issues
fixes #3243