-
Notifications
You must be signed in to change notification settings - Fork 49
Exposing vector_add to zok frontend #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 2 commits
66438fb
b1cceff
f9619f4
a3d1f2f
49576d2
47fbdb8
3a065c0
123e691
d976738
8887be7
7057117
e246ddc
04d9785
c8608b3
47c0a40
8c5d3f7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| from "EMBED" import vector_add | ||
|
|
||
| def main() -> u32[5]: | ||
| u32[5] a = [1, 2, 3, 4, 5] | ||
| u32[5] b = [2, 3, 4, 5, 6] | ||
| return vector_add(a,b) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| from "EMBED" import vector_add | ||
|
|
||
| def main() -> u32[5]: | ||
| u32[5] a = [1, 2, 3, 4, 5] | ||
| u32[5] b = [] | ||
| return vector_add(a,b) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,3 +75,7 @@ def u16_to_u32(u16 i) -> u32: | |
|
|
||
| def u8_to_u16(u8 i) -> u16: | ||
| return 0u16 | ||
|
|
||
| // vector functions | ||
| def vector_add<N>(u32[N] a, u32[N] b) -> u32[N]: | ||
| return [0; N] | ||
|
Comment on lines
+79
to
+90
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think if you're only going to support one type here it should be
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think only BV are currently supported in the FHE backend, which is why I left it as u32.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still, it might make sense to support all the basic types, no? It wouldn't be much extra work:
Since this is so simple, I don't see a reason to leave it half-done. But I could be missing something!
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see, updated! |
||
Uh oh!
There was an error while loading. Please reload this page.