[Param Update 1 of 2] Quoted string parameters in parameter files - #503
Open
mabruzzo wants to merge 16 commits into
Open
[Param Update 1 of 2] Quoted string parameters in parameter files#503mabruzzo wants to merge 16 commits into
mabruzzo wants to merge 16 commits into
Conversation
I also changed the namespace that they are a part of
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not be reviewed until after #492 has been merged
This PR modifies Cholla so that all strings in the parameter files are quoted.
Important
This would be a backwards incompatible change. As such, I realize that it may take a long time to get merged (or it may be closed).
Motivation
If this PR is merged, Cholla's parameter files will be a strict subset of the TOML format. This has a few benefits:
Handling of whitespace in string values is no longer ambiguous.
We can start using an external TOML parsing library (there are a handful of nice C++ implementations that we can use simply by vendoring a single header file). This lets us get rid of the underlying parsing logic, and lets us fully use some of TOML's nice features (namely tables and arrays).
It will be possible to easily read the input parameter files with any valid TOML parsing library. This could be useful in analysis.
Relatedly, we could more easily programmatically modify Cholla input files (yeah, this is niche, but when it comes up, it's quite nice!)
What has changed