fix(synthcity): fix synthcity attack metric calculation and other related downstream changes - #11
Merged
Merged
Conversation
…ated downstream changes Fixes #6
Contributor
There was a problem hiding this comment.
Pull request overview
Updates synthcity attack metric naming and downstream privacy classification.
Changes:
- Renames the metric category from
attacksto nativeattack. - Classifies attack results as privacy metrics.
- Adds unit tests for selection and result orientation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
synthdata/evaluation/catalog.py |
Updates attack category naming and classification. |
tests/unit/test_synthcity_eval.py |
Tests attack metric selection. |
tests/unit/test_evaluation_combine.py |
Tests attack result classification and orientation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6