Skip CcdCallBacks() when no timer callbacks are registered - #198
Merged
Conversation
CsdScheduler and CsdSchedulePoll called CcdCallBacks() unconditionally on every trip round the loop. That costs a CmiWallTimer() (~60 ns on Delta) plus a heap probe per iteration even when no timer callback exists, which is the case for any program that does not register one. Restore the original Converse guard: CcdNumTimerCBs() > 0 collapses the whole thing to one predictable branch when nothing is timer-based, and the _ccd_numchecks countdown bounds the cost when something is. _ccd_numchecks was already declared here but never used to gate anything; the adaptive nSkip retuning that maintains it had been dropped in the port and is restored alongside it. Verified against tests/conds: the 1s/5s/10s periodic conditions and the 7s CcdCallFnAfter all still fire, with no added lag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CsdScheduler and CsdSchedulePoll called CcdCallBacks() unconditionally on every trip round the loop. That costs a CmiWallTimer() (~60 ns on Delta) plus a heap probe per iteration even when no timer callback exists, which is the case for any program that does not register one.
Restore the original Converse guard: CcdNumTimerCBs() > 0 collapses the whole thing to one predictable branch when nothing is timer-based, and the _ccd_numchecks countdown bounds the cost when something is. _ccd_numchecks was already declared here but never used to gate anything; the adaptive nSkip retuning that maintains it had been dropped in the port and is restored alongside it.
Verified against tests/conds: the 1s/5s/10s periodic conditions and the 7s CcdCallFnAfter all still fire, with no added lag.