Entry color choosers: search box, and only in-range entries in Time Profile - #157
Merged
Conversation
Long entry method lists are hard to scroll through when hunting for one name. Both list dialogs (entry methods, and Timeline's user events) get a Search field above the table that filters rows live as you type: case-insensitive substring match on the name or ID columns, via a TableRowSorter used only for filtering (column-click sorting stays off since the color column is not comparable; row-index conversion keeps color editing on the right row while filtered). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The Color Scheme chooser listed every entry method in the STS file; Timeline's chooser already restricts itself to entries present in the loaded data. GenericGraphWindow gains a getEntryFilter() hook (default null keeps the old behavior for other tools), and TimeProfileWindow implements EntryMethodVisibility backed by its existsArray, so the chooser shows exactly the EPs in the picture plus Idle/Overhead. Falls back to the full list until data has loaded. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
initAnalysis failures (e.g. a moved trace file) already show an error dialog, but done() still called updateStatusSTS(null) and threw. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lvkale
requested review from
ericjbohm,
matthiasdiener and
ritvikrao
as code owners
July 28, 2026 04:43
ritvikrao
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality-of-life improvements to the entry method color/visibility choosers:
getEntryFilter()hook in GenericGraphWindow (default null preserves existing behavior for other tools) with TimeProfileWindow implementingEntryMethodVisibilitybacked by its existingexistsArray.🤖 Generated with Claude Code