fix: style 'unknown help topic' errors - #99
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
Cobra's default help command prints 'Unknown help topic' to stdout and returns nil, so fang's ErrorHandler never sees it. Swap in a help command whose RunE returns an error in that case so the styled handler runs. Closes charmbracelet#61. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cobra's default help command prints "Unknown help topic" straight to stdout and returns nil, so fang's ErrorHandler never sees it and the message lands unstyled. This swaps in a help command whose
RunEreturns an error for unknown topics, so the configured error handler picks it up like any other usage error.The golden update for
with_command_groups/helpis the same dedupe of triplicatedCOMMANDSsections that #97 also makes. If #97 lands first I'll rebase.Closes #61.