fix: include CH32H* family in metapac gen targets - #41
Merged
Conversation
PR #39 added CH32H417/H416/H415 chip yaml under data/chips/ but the `./d gen` invocation enumerates families explicitly and was never updated to pass `CH32H*`, so the published ch32-metapac is missing H4 chips even on the tag generated from the H4 merge commit (5e8d693). Add the glob to match the same pattern used for the other families.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./d genenumerates families explicitly when invokingch32-metapac-gendata/chips/but didn't addCH32H*to the gen invocationch32-metapacthat has no H4 chips"CH32H*"alongside the other family globsTest plan
rm -rf build && ./d genfrom this branch produces 10 H4 chip directories underbuild/ch32-metapac/src/chips/(5 SKUs × V3F/V5F cores)ch32-halH4 work) can drop their local[patch."https://github.com/ch32-rs/ch32-metapac"]