CFE-3882: Added date binary inside cfengine - #2450
Merged
Merged
Conversation
victormlg
changed the title
|
Thanks for submitting a PR! Maybe @craigcomstock can review this? |
nickanderson
approved these changes
Aug 24, 2026
nickanderson
left a comment
nickanderson
left a comment
Member
There was a problem hiding this comment.
Seems reasonable, though I still wish we didn't have to exec out
craigcomstock
approved these changes
Aug 24, 2026
larsewi
requested changes
Aug 25, 2026
Added /var/cfengine/bin/date from coreutils, in a similar way to diff, to be able to parse date and time Signed-off-by: Victor Moene <victor.moene@northern.tech>
larsewi
approved these changes
Aug 25, 2026
Comment on lines
+95
to
+100
| +/* Resolving a user/group spec requires looking it up via the system's | ||
| + user and group databases, so the code below needs <pwd.h> and | ||
| + <grp.h>. On platforms that lack these headers (e.g. native Windows), | ||
| + omit it entirely rather than fake up the lookups: if some program | ||
| + actually needs it, it will fail to link, which is preferable to | ||
| + silently linking in a passwd/group lookup that can never work. */ |
Contributor
There was a problem hiding this comment.
People reading this in the future will have no context of the fake look-ups that used to be there.
Comment on lines
+6
to
+23
| We only build the "date" program out of coreutils, but the build compiles | ||
| every gnulib lib/*.c file into a single lib/libcoreutils.a used by all | ||
| coreutils programs, regardless of whether "date" actually needs them. | ||
|
|
||
| lib/idcache.c and lib/userspec.c unconditionally include <pwd.h> and | ||
| <grp.h> to resolve uids/gids via the system's user and group databases. | ||
| Native Windows (mingw-w64) ships neither header, so compiling | ||
| lib/libcoreutils.a for date.exe failed there even though date.exe never | ||
| references any symbol from these two files. | ||
|
|
||
| Guard the includes, and the function bodies that depend on them, with | ||
| the HAVE_PWD_H/HAVE_GRP_H macros that configure already defines via | ||
| AC_CHECK_HEADERS. This way the two files compile down to empty | ||
| translation units on platforms lacking these headers. If some other | ||
| coreutils program actually needs the passwd/group lookups these files | ||
| provide, linking that program will now fail with an undefined | ||
| reference, surfacing the problem at build time instead of silently | ||
| linking in stub declarations that could never work. |
Contributor
There was a problem hiding this comment.
This you could probably explain with a few sentences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.