Conversation
reomve some unavilable QoS params from nvmeof's VolumeAttributesClass example file. Also, rename them. this file was added early with wrong QoS params names. Caught by QE team. Signed-off-by: gadi-didi <gadi.didi@ibm.com>
mergify
Bot
added
component/testing
gadididi
added
component/docs
mergify
Bot
added
component/testing
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The example now reflects supported QoS parameters with no unresolved issues.
Review effort: Lite
Findings: None
What changed in this PR
Updates the NVMe-oF VolumeAttributesClass example with supported QoS parameter names and removes unavailable options.
Changes:
- Renamed QoS parameters to match the implementation.
- Removed unsupported read/write-specific IOPS parameters.
- Retained supported throughput limits.
| File | Description |
|---|---|
examples/nvmeof/volumeattributesclass.yaml |
Corrects documented NVMe-oF QoS parameters. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nixpanic
approved these changes
Sep 24, 2026
nixpanic
added
ci/skip/e2e
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove some unavailable QoS params from nvmeof's
VolumeAttributesClassexample file.Also, rename them. this file was added early with
wrong QoS params names.
Caught by QE team.