Conversation
Merge Protections🟢 All 2 merge protections satisfied — ready to merge. Show 2 satisfied protections🟢 📃 Configuration Change RequirementsMergify configuration change
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
There was a problem hiding this comment.
🟢 Approval recommended
The CI and Mergify changes are aligned; the remaining documentation mismatch is a minor nit and does not block approval.
Pull request overview
Updates CI to test Kubernetes 1.37 and restrict devel testing to Kubernetes 1.36 and 1.37.
Changes:
- Adds Kubernetes 1.37 to the test matrix.
- Excludes Kubernetes 1.32–1.35 from
develand 1.37 from release branches. - Updates Mergify queue requirements.
File summaries
| File | Summary |
|---|---|
.mergify.yml |
Updates required devel CI statuses. |
.github/workflows/pull-request-commentor.yaml |
Adds Kubernetes 1.37 and branch-specific exclusions. |
Review details
Suppressed comments (1)
.github/workflows/pull-request-commentor.yaml:22
- This changes the devel CI matrix to test only Kubernetes 1.36 and 1.37, but the public “Known to work CO platforms” table still lists devel as tested on 1.34, 1.35, and 1.36 (
README.md:61). Please update that row in the same change so the documented support matrix matches the jobs this workflow actually triggers and includes 1.37.
k8s: ["1.32", "1.33", "1.34", "1.35", "1.36", "1.37"]
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
/test ci/centos/mini-e2e/k8s-1.37/rbd |
|
/test ci/centos/mini-e2e/k8s-1.37/nfs |
Failed (logs) |
NFS failure: (logs) |
|
/test ci/centos/mini-e2e/k8s-1.37/cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
|
/test ci/centos/k8s-e2e-external-storage/1.36 |
|
/test ci/centos/mini-e2e/k8s-1.36 |
|
/test ci/centos/mini-e2e/k8s-1.34 |
|
/test ci/centos/k8s-e2e-external-storage/1.35 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e/k8s-1.35 |
|
/test ci/centos/upgrade-tests-rbd |
|
@Mergifyio rebase |
❌ This pull request comes from a fork and cannot be rebasedDetailsGitHub refuses an OAuth token on its rebase API for a fork, so rebasing one means impersonating a GitHub user to force-push the contributor's branch. Mergify does not do that. Use the |
|
@Mergifyio update |
|
@mergify update |
❌ Pull request can't be updated with latest base branch changesDetailsThis pull request seems to come from a fork, and Mergify needs the author's permission to update its branch. |
|
@Mergifyio rebase |
❌ This pull request comes from a fork and cannot be rebasedDetailsGitHub refuses an OAuth token on its rebase API for a fork, so rebasing one means impersonating a GitHub user to force-push the contributor's branch. Mergify does not do that. Use the |
|
@Mergifyio rebase |
❌ This pull request comes from a fork and cannot be rebasedDetailsGitHub refuses an OAuth token on its rebase API for a fork, so rebasing one means impersonating a GitHub user to force-push the contributor's branch. Mergify does not do that. Use the |
|
@Mergifyio update |
❌ GitHub refused to update workflow filesDetailsGitHub response: refusing to allow a GitHub App to create or update workflow |
|
Lots of CI jobs failed with NFS issues, #6560 disables the requirement to pass that. |
|
@Mergifyio rebase |
❌ This pull request comes from a fork and cannot be rebasedDetailsGitHub refuses an OAuth token on its rebase API for a fork, so rebasing one means impersonating a GitHub user to force-push the contributor's branch. Mergify does not do that. Use the |
|
@Mergifyio update |
❌ GitHub refused to update workflow filesDetailsGitHub response: refusing to allow a GitHub App to create or update workflow |
|
@nixpanic I think you would need to update Mergifyio's permissions or you would need to manually rebase it? |
The Ceph team has accepted the updated permissions for Mergify in the Ceph GitHub Org last week. @Mergifyio rebase |
|
@Mergifyio rebase |
❌ This pull request comes from a fork and cannot be rebasedDetailsGitHub refuses an OAuth token on its rebase API for a fork, so rebasing one means impersonating a GitHub user to force-push the contributor's branch. Mergify does not do that. Use the |
|
@Mergifyio update |
❌ Pull request can't be updated with latest base branch changesDetailsThis pull request seems to come from a fork, and Mergify needs the author's permission to update its branch. |
|
@mergify, you're being weird... Whay did you rebase other PRs today? |
Add k8s 1.37 to the test matrix and restrict devel to only 1.36 and 1.37 by excluding 1.32, 1.33, 1.34 and 1.35. k8s 1.37 is excluded from release-v3.16 and release-v3.17. Assisted-by: AskBob <askbob@ibm.com> Signed-off-by: Niels de Vos <ndevos@ibm.com>
Update the Mergify queue conditions to match the updated CI matrix: only k8s 1.36 and 1.37 are tested on devel, so drop the 1.34 and 1.35 status-success requirements and add 1.37. Assisted-by: AskBob <askbob@ibm.com> Signed-off-by: Niels de Vos <ndevos@ibm.com>
292171a to
df49430
Compare
Pull request has been modified.
|
Depends-On: #6582 |
Add k8s 1.37 to the test matrix and restrict devel to only
1.36 and 1.37 by excluding 1.32, 1.33, 1.34 and 1.35.
k8s 1.37 is excluded from release-v3.16 and release-v3.17.
Update the Mergify queue conditions to match the updated CI
matrix: only k8s 1.36 and 1.37 are tested on devel, so drop
the 1.34 and 1.35 status-success requirements and add 1.37.
Closes: #6469