e2e: remove helm tests by iPraveenParihar · Pull Request #6512 · ceph/ceph-csi

iPraveenParihar · 2026-08-27T12:31:54Z

Describe what this PR does

Removes Helm-based deployment testing from the e2e suite and CI. Helm charts
are being deprecated in favor of the Ceph-CSI Operator (will be deprecated in v3.18,
to be removed in v3.19), so Helm e2e coverage is no longer needed on devel.

Part-of: #6467

Future concerns

List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.

Checklist:

Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
Reviewed the developer guide on Submitting a Pull Request
Pending release notes updated with breaking and/or notable changes for the next major release.
Documentation has been updated, if necessary.
Unit tests have been added, if necessary.
Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)

CI job ordering

Depends-on: #6538

mergify · 2026-08-27T12:32:35Z

Merge Protections

🟢 All 3 merge protections satisfied — ready to merge.

Show 3 satisfied protections

🟢 ⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

depends-on = ceph/ceph-csi#6538 [⛓️ deploy: use single worker thread in csi-provisioner for NVMe-oF #6538]

🟢 📃 Configuration Change Requirements

Mergify configuration change

any of:
- check-success = @mergify/Configuration changed
- check-success = @mergify/Configuration has been deleted

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

iPraveenParihar · 2026-08-27T12:39:48Z

Lets remove helm tests first to have 3 less CI 😄.

mergify · 2026-09-01T11:43:37Z

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

iPraveenParihar · 2026-09-01T12:17:22Z

/test ci/centos/mini-e2e/k8s-1.36

Copilot

Pull request overview

Removes Helm-based deployment coverage from the Ceph-CSI E2E suite and updates CI automation/gating to reflect Helm deprecation on devel, aligning test strategy with the move toward Ceph-CSI Operator deployments.

Changes:

Removed Helm-specific E2E mode (--helm-test) and Helm-only test cases, plus related pod-selection logic.
Simplified namespace/setup logic to account for Operator deployments without Helm special-casing.
Updated merge gating and PR automation to stop requiring/triggering Helm E2E on devel, and documented the deprecation in pending release notes.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
PendingReleaseNotes.md	Adds a deprecation note explaining Helm E2E validation is removed.
e2e/utils.go	Removes Helm-related fields and narrows CSI pod selector to deployment/daemonset names.
e2e/upgrade-rbd.go	Drops Helm-specific namespace handling during upgrade tests.
e2e/upgrade-cephfs.go	Drops Helm-specific namespace handling during upgrade tests.
e2e/rbd.go	Removes Helm-only test and setup branching (labels/storageclass), and removes Helm pod label from deployment struct.
e2e/operator.go	Updates operator pod selector to no longer include Helm labels.
e2e/nvmeof.go	Removes Helm from skip logic (Operator-only special-casing remains).
e2e/nfs.go	Removes Helm gating and Helm pod label from operator deployment struct usage.
e2e/e2e_test.go	Removes the `--helm-test` flag from the E2E test binary.
e2e/cephfs.go	Removes Helm-only test and Helm pod label from deployment struct.
.mergify.yml	Removes Helm E2E job statuses from merge requirements.
.github/workflows/pull-request-commentor.yaml	Stops posting Helm E2E trigger comments for PRs targeting `devel`.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

iPraveenParihar · 2026-09-02T06:01:36Z

 func (r *OperatorDeployment) getPodSelector() string {
-	return fmt.Sprintf("app in (%s, %s, %s, %s, %s)", helmRBDPodsLabel, helmCephFSPodsLabel, helmNFSPodsLabel,
-		r.deploymentName, r.daemonsetName)
+	return fmt.Sprintf("app in (%s, %s)", r.deploymentName, r.daemonsetName)
 }


Will do it when we remove the manifest deployment.

black-dragon74

Minor nits, rest LGTM :)

iPraveenParihar · 2026-09-07T06:44:35Z

upgrade test passed logs

iPraveenParihar · 2026-09-07T06:44:46Z

/test ci/centos/mini-e2e-operator/k8s-1.35

Remove the --helm-test flag and all helm-specific test code paths from the e2e test suite. Helm deployments are deprecated and will no longer be tested. Signed-off-by: Praveen M <m.praveen@ibm.com>

Remove helm e2e test triggers from the pull request commentor workflow. Helm deployments are deprecated and will no longer be tested in CI. Signed-off-by: Praveen M <m.praveen@ibm.com>

Signed-off-by: Praveen M <m.praveen@ibm.com>

iPraveenParihar · 2026-09-07T09:55:57Z

/test ci/centos/mini-e2e-operator/k8s-1.35

iPraveenParihar · 2026-09-07T11:44:59Z

/test ci/centos/mini-e2e/k8s-1.35

nixpanic · 2026-09-10T10:45:05Z

wait for #6538 to be merged before /queue'ing this PR.

nixpanic · 2026-09-10T11:19:08Z

/queue

ceph-csi-bot · 2026-09-10T11:19:32Z

@Mergifyio rebase

mergify · 2026-09-10T11:19:42Z

rebase

❌ This pull request comes from a fork and cannot be rebased

Details

GitHub refuses an OAuth token on its rebase API for a fork, so rebasing one means impersonating a GitHub user to force-push the contributor's branch. Mergify does not do that.

Use the update action or the @mergifyio update command instead: it brings the pull request up to date by merging the base branch into it, and needs no impersonation. It only has something to do when the pull request is behind its base branch, so if what the branch needs is a linear history, its author has to rebase it themselves.

nixpanic · 2026-09-10T11:21:20Z

@Mergifyio update

mergify · 2026-09-10T11:21:26Z

update

❌ Pull request can't be updated with latest base branch changes

Details

This pull request seems to come from a fork, and Mergify needs the author's permission to update its branch.
The author needs to enable "Allow edits from maintainers" on this pull request, or update the branch manually.

nixpanic · 2026-09-10T11:25:24Z

@Mergifyio queue

mergify · 2026-09-10T11:25:31Z

Merge Queue Status

🛑 Queue command has been cancelled

nixpanic · 2026-09-10T11:26:34Z

/test ci/centos/upgrade-tests

nixpanic · 2026-09-10T12:03:54Z

@Mergifyio refresh

mergify · 2026-09-10T12:04:16Z

queue

🛑 This pull request comes from a fork and cannot be rebased on behalf of a user

Details

GitHub refuses an OAuth token on its rebase API for a fork, so rebasing a fork's pull request on behalf of a GitHub user means impersonating that user to force-push the contributor's branch. Mergify does not do that.

Unset update_bot_account on the default queue to keep queueing pull requests from forks: with no account to impersonate, the update rebases through GitHub's API as Mergify, which the installation token is allowed to do. A fork pull request that changes GitHub Actions workflows, or that another GitHub App's bot opened, is the exception: GitHub lets Mergify queue one in place only with an update_bot_account, so a queue that receives those has to run its checks on a draft pull request instead. update_method: merge works too, and merges the base branch into the pull request rather than rebasing it.

mergify · 2026-09-10T12:04:17Z

refresh

✅ Pull request refreshed

iPraveenParihar requested review from a team as code owners August 27, 2026 12:31

mergify Bot added component/testing Additional test cases or CI work component/deployment Helm chart, kubernetes templates and configuration Issues/PRs labels Aug 27, 2026

This was referenced Aug 27, 2026

Prepare for Ceph-CSI Operator deployment everywhere #6467

Open

cleanup: deprecate charts yamls manifests #6507

Open

nixpanic reviewed Aug 27, 2026

View reviewed changes

Comment thread .github/workflows/pull-request-commentor.yaml

nixpanic reviewed Aug 27, 2026

View reviewed changes

Comment thread PendingReleaseNotes.md Outdated

iPraveenParihar force-pushed the e2e/remove-helm-tests branch 2 times, most recently from f004ae1 to a1d826d Compare August 27, 2026 13:01

iPraveenParihar added the ci/skip/multi-arch-build skip building on multiple architectures label Aug 27, 2026

iPraveenParihar force-pushed the e2e/remove-helm-tests branch from a1d826d to c5c888a Compare August 27, 2026 13:22

iPraveenParihar requested review from a team and nixpanic August 27, 2026 15:43

iPraveenParihar mentioned this pull request Sep 1, 2026

rebase: bump google.golang.org/grpc from 1.82.1 to 1.83.2 in /e2e #6518

Merged

iPraveenParihar force-pushed the e2e/remove-helm-tests branch from c5c888a to 2011228 Compare September 1, 2026 12:15

Rakshith-R requested a lite review from Copilot September 1, 2026 14:30

Copilot started reviewing on behalf of Rakshith-R September 1, 2026 14:31 View session

Copilot AI reviewed Sep 1, 2026

View reviewed changes

black-dragon74 reviewed Sep 2, 2026

View reviewed changes

Comment thread e2e/rbd.go Outdated

black-dragon74 reviewed Sep 2, 2026

View reviewed changes

Comment thread e2e/rbd.go Outdated

black-dragon74 reviewed Sep 2, 2026

View reviewed changes

Comment thread PendingReleaseNotes.md Outdated

black-dragon74 requested changes Sep 2, 2026

View reviewed changes

iPraveenParihar force-pushed the e2e/remove-helm-tests branch 2 times, most recently from b6a6513 to f67462f Compare September 2, 2026 06:58

iPraveenParihar force-pushed the e2e/remove-helm-tests branch from 8daacf6 to 442f816 Compare September 7, 2026 06:44

iPraveenParihar added 3 commits September 7, 2026 15:23

e2e: remove helm deployment testing support

19469e1

Remove the --helm-test flag and all helm-specific test code paths from the e2e test suite. Helm deployments are deprecated and will no longer be tested. Signed-off-by: Praveen M <m.praveen@ibm.com>

ci: remove helm e2e test triggers for devel branch

0a58b87

Remove helm e2e test triggers from the pull request commentor workflow. Helm deployments are deprecated and will no longer be tested in CI. Signed-off-by: Praveen M <m.praveen@ibm.com>

doc: update pendingReleaseNotes

623bfa2

Signed-off-by: Praveen M <m.praveen@ibm.com>

iPraveenParihar force-pushed the e2e/remove-helm-tests branch from 442f816 to 623bfa2 Compare September 7, 2026 09:53

iPraveenParihar requested review from a team and black-dragon74 September 8, 2026 05:08

black-dragon74 approved these changes Sep 8, 2026

View reviewed changes

Rakshith-R approved these changes Sep 10, 2026

View reviewed changes

nixpanic mentioned this pull request Sep 10, 2026

Feat/nfs export names #6497

Open

6 tasks

nixpanic approved these changes Sep 10, 2026

View reviewed changes

ceph-csi-bot added the queued/rebase label Sep 10, 2026

nixpanic added the ci/skip/e2e skip running e2e CI jobs label Sep 10, 2026

nixpanic merged commit 3c71c74 into ceph:devel Sep 10, 2026
30 of 31 checks passed

Uh oh!

Conversation

iPraveenParihar commented Aug 27, 2026 • edited by nixpanic Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe what this PR does

Future concerns

Uh oh!

mergify Bot commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Protections

🟢 ⛓️ Depends-On Requirements

🟢 📃 Configuration Change Requirements

🟢 🚦 Auto-queue

Uh oh!

iPraveenParihar commented Aug 27, 2026

Uh oh!

Uh oh!

Uh oh!

mergify Bot commented Sep 1, 2026

Uh oh!

iPraveenParihar commented Sep 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

iPraveenParihar Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

black-dragon74 left a comment

Choose a reason for hiding this comment

Uh oh!

iPraveenParihar commented Sep 7, 2026

Uh oh!

iPraveenParihar commented Sep 7, 2026

Uh oh!

iPraveenParihar commented Sep 7, 2026

Uh oh!

iPraveenParihar commented Sep 7, 2026

Uh oh!

nixpanic commented Sep 10, 2026

Uh oh!

nixpanic commented Sep 10, 2026

Uh oh!

ceph-csi-bot commented Sep 10, 2026

Uh oh!

mergify Bot commented Sep 10, 2026

❌ This pull request comes from a fork and cannot be rebased

Uh oh!

nixpanic commented Sep 10, 2026

Uh oh!

mergify Bot commented Sep 10, 2026

❌ Pull request can't be updated with latest base branch changes

Uh oh!

nixpanic commented Sep 10, 2026

Uh oh!

mergify Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

nixpanic commented Sep 10, 2026

Uh oh!

nixpanic commented Sep 10, 2026

Uh oh!

mergify Bot commented Sep 10, 2026

🛑 This pull request comes from a fork and cannot be rebased on behalf of a user

Uh oh!

mergify Bot commented Sep 10, 2026

✅ Pull request refreshed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

iPraveenParihar commented Aug 27, 2026 •

edited by nixpanic

Loading

mergify Bot commented Aug 27, 2026 •

edited

Loading

mergify Bot commented Sep 10, 2026 •

edited

Loading