testvectors: check exported private dh key matches x or clamped(x) - #1
Open
robinhundt wants to merge 1 commit into
Open
robinhundt wants to merge 1 commit into
robinhundt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I tried out the suggestion by @chrysn lake-rs#114 (comment) .
I'm not sure I like this approach. While it could catch an abnormal
exportimplementation that would be permitted by the previous property, this feels a bit overcomplicated for the test.Previously, I tried just testing
exported == private_clamped_bytes.unwrap_or(private_bytes), but that failed for the rust-crypto backend, as it doesn't store the private key in the clamped form, as the implementation does the clamping internally. So the exported bytes there are the unclamped bytes.I wonder whether the contract on
import/exportshould maybe be tightened, so that it is guaranteed that they're idempotent. This would require a change in either the nrf or rust-crypto backend for these curves. The non-idempotency could easily trip people up, as it did for me.