Re-packaged all indomptency issues and aligned new Vite build with co… - #1296
Merged
Merged
Conversation
|
@Sadeequ Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Nice implementation, LGTM! 🚀 Great work on this contribution — the approach is clean and well thought out. Thanks for contributing to AnchorPoint! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Report
Issue 1: Proxy Upgrade Timelock
I added
request_implementation_upgradeinlib.rs. It requires admin authorization, records the proposed implementation and a 24-hour unlock time in storage dedicated to implementation swaps, and emits a request event.I changed
upgradeto require a matching pending proposal and an expired timelock before swapping. After a successful swap, I clear the pending implementation and unlock time. I also updated the deployment comment to describe the schedule-then-execute flow.Issue 2: Atomic Batch Rollback
I changed
execute_batch_with_retryinlib.rsso thatabort_on_failure = truepanics as soon as an operation exhausts its retries. That aborts the Soroban invocation, reverting earlier successful operations and the nonce instead of returning a partial result and merely skipping later calls.I updated the related test in
test.rsto run a successful state-changing operation before a failing one, then assert that both its state change and the nonce were rolled back. I also removed duplicate test imports that were already present in that file.Issue 3: Isolated Dashboard Errors
I added a compact fallback mode to
GlobalErrorBoundary.tsxand wrapped the active dashboard view in it fromApp.tsx. A section render failure now displays a local alert instead of replacing the whole application shell.I added
GlobalErrorBoundary.test.tsxto verify that the fallback appears while sibling navigation remains rendered.Issue 4: Dashboard Code Splitting
I replaced the inline placeholder overview, transaction history, and SEP-24 sections with lazy imports of the existing page components in
App.tsx. I wrapped the active view inSuspensewith a loading fallback. The production Vite build emitted separateDashboardOverview,TransactionHistory, andSEP24Flowchunks.Related Issues