Skip to content

test ut - #1998

Open
sahusanket wants to merge 1 commit into
developfrom
test_mvn_dep
Open

test ut#1998
sahusanket wants to merge 1 commit into
developfrom
test_mvn_dep

Conversation

@sahusanket

Copy link
Copy Markdown
Contributor

No description provided.

@sahusanket sahusanket added the build Trigger unit test build label Jul 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the smbj dependency to core-plugins/pom.xml. The reviewer suggests setting the dependency scope to test to avoid including it in the production artifact, as it is only intended for unit testing.

Comment thread core-plugins/pom.xml
Comment on lines +308 to +312
<dependency>
<groupId>com.hierynomus</groupId>
<artifactId>smbj</artifactId>
<version>0.11.5</version>
</dependency>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The smbj dependency is added without a scope, which defaults to compile scope and packages it into the final build. Since this pull request is for unit testing ("test ut"), this dependency should be scoped to test to avoid unnecessarily increasing the production artifact size.

    <dependency>
      <groupId>com.hierynomus</groupId>
      <artifactId>smbj</artifactId>
      <version>0.11.5</version>
      <scope>test</scope>
    </dependency>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Trigger unit test build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant