Skip to content

Reduce pre-existing duplicate-code inspection baseline #549

Description

@shiny-code-bot

Objective

Reduce or explicitly baseline the remaining file-wide PyCharm duplicate-code warnings in the GitHub helper and regression-test surfaces without broad suppressions or unrelated behavioral changes.

Finish Line

The current duplicate-code findings are either eliminated through maintainable shared helpers or documented as intentional, narrowly scoped accepted debt with reproducible inspection evidence.

Current Status

State: Later, non-blocking; parked pending selection of a focused duplicate-code cluster.
Parked until: a reproducible cluster can be improved without weakening fail-closed behavior or obscuring higher-priority work. No implementation slice is selected by this reconciliation.
Next action: select that bounded slice when this maintenance work is brought into focus.
Last verified: 2026-09-14 UTC; issue scope and current evidence pointers reconciled.

The duplicate-code findings remain pre-existing maintenance debt rather than a correctness, release, or inspection-trust blocker. The completed Trustworthy JetBrains Inspection Evidence milestone does not require this baseline cleanup. The fully retrieved inspection in PR #631 reproduced seven inherited duplicate-code findings; its evidence and triage remain with that PR.

Keep this work separate from #550 and #533. Do not fold broad duplicate-code refactors into contract vendoring, test-value audit, or Astra-study helper repairs. The waiting status records the existing Later decision; it does not create a new dependency or change priority.

Acceptance Criteria

  • Reproduce the current warnings with an explicit committed-file PyCharm inspection and record the exact profile/tool revision.
  • Separate genuinely duplicated behavior from false-positive structural similarity.
  • Refactor only coherent clusters where a shared helper improves clarity and preserves fail-closed semantics.
  • Do not add broad suppressions or disable duplicate-code inspection.
  • Keep GitHub auth, actor identity, retry, reconciliation, and redaction behavior covered by focused tests.
  • Run repository-wide validation and a final explicit-file inspection.

Relationships

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    planDurable planning issueplan:waitingPlan is waiting on non-issue evidence or decision

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions