Skip to content
This repository was archived by the owner on Apr 21, 2026. It is now read-only.

NOJIRA: logging and API URL improvements#35

Merged
Tsonov merged 7 commits into
masterfrom
NOJIRA-logging-and-apipath-improvements
Mar 9, 2026
Merged

NOJIRA: logging and API URL improvements#35
Tsonov merged 7 commits into
masterfrom
NOJIRA-logging-and-apipath-improvements

Conversation

@Tsonov
Copy link
Copy Markdown
Contributor

@Tsonov Tsonov commented Mar 5, 2026

Changes:

  • Prepend https:// if API_URL has no protocol. Otherwise resty fails to send requests with protocol scheme error - and that is rarely discovered as it only occurs during spot interruption, when the pod is already dying.
  • Respect log level from config
  • Log more things in general

Why:

  • It's easy to misconfigure API URL without protocol as it's not intuitive that the library requires it (resty)
  • Users don't see logs and think nothing is happening (or even worse, they see a few failed attempts that are logged and assume the handler is broken)
  • Termination and stopping also logs nothing, giving no info to user
  • The log level was not respected and was always Info for non-resty operations

@Tsonov Tsonov merged commit ea0b1ff into master Mar 9, 2026
2 checks passed
@Tsonov Tsonov deleted the NOJIRA-logging-and-apipath-improvements branch March 9, 2026 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants