feat: Migrate smoke tests to terminal bench runner#140
Open
feat: Migrate smoke tests to terminal bench runner#140
Conversation
Kimchi Code ReviewA review is being prepared and will be posted shortly.
What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kimchi Summary
What changed
Adds a new
terminal-bench-smokebenchmark suite with three tasks (two Go coding tasks and one research task) that reuse theterminal-bench-2harness. Also extends thekimchi_agentto support runtime toggling between orchestrator and single-model execution modes via theKIMCHI_MULTI_MODELenvironment variable.Why
Provides a lightweight, fast-feedback smoke test suite for validating kimchi-code changes without running the full benchmark. The single-model toggle eliminates the need to duplicate task definitions when comparing orchestrator behavior against standalone model performance.
Key changes
benchmark/terminal-bench-2/src/kimchi_agent/agent.py: DetectsKIMCHI_MULTI_MODEL=false(via--aeflags) and appends--multi-model=falseto CLI invocation, allowing single-model execution of any task.benchmark/terminal-bench-smoke/: New smoke test directory containing:tasks/go-rate-limiter/: Token-bucket HTTP middleware implementation task with black-box verifier testing burst limits and per-IP isolation.tasks/go-task-api/: Layered REST API task (POST/GET/PATCH/DELETE) with end-to-end HTTP contract verification.tasks/go-router-research/: Research task with trivial verifier (only checks/app/answer.mdexists and is non-empty); intended for comparing token usage and subagent behavior rather than reward.scripts/run-local.sh: Cross-builds Linux binary from working tree and executes smoke suite.scripts/run-release.sh: Executes smoke suite against latest published kimchi-code release.README.md: Usage examples including single-model tagging syntax (--ae KIMCHI_MULTI_MODEL=false --ae KIMCHI_TAGS=mode:single).