feat(core): Updates to nut18 and nut26 payment request#1059
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1059 +/- ##
==========================================
+ Coverage 74.64% 75.36% +0.72%
==========================================
Files 111 111
Lines 12387 12542 +155
==========================================
+ Hits 9246 9452 +206
+ Misses 3141 3090 -51 ☔ View full report in Codecov by Harness. |
|
@KvngMikey If I am not mistaken this only adds support for decoding such payment requests with the additional fields but does not add any logic to handle them or to create a payment request with them. |
@a1denvalu3 you're right that this PR only adds encoding/decoding for the new ms / fr / sm fields and doesn't add enforcement logic. Happy to either extend this PR with that handling + a request-creation path, or land this as the serialization layer and do the behavior in a focused follow-up. Which would you prefer? |
Yes please |
…quest that carries fields
|
The nut has been updated: |
implements cashubtc/nuts#381 to keep Nutshell up to date !