Skip to content

feat(core): Updates to nut18 and nut26 payment request#1059

Open
KvngMikey wants to merge 5 commits into
cashubtc:mainfrom
KvngMikey:payment_request_update
Open

feat(core): Updates to nut18 and nut26 payment request#1059
KvngMikey wants to merge 5 commits into
cashubtc:mainfrom
KvngMikey:payment_request_update

Conversation

@KvngMikey

Copy link
Copy Markdown
Collaborator

implements cashubtc/nuts#381 to keep Nutshell up to date !

Copilot AI review requested due to automatic review settings June 21, 2026 09:50
@github-project-automation github-project-automation Bot moved this to Backlog in nutshell Jun 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.36%. Comparing base (e665f46) to head (11612fe).
⚠️ Report is 27 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
+ Coverage   74.64%   75.36%   +0.72%     
==========================================
  Files         111      111              
  Lines       12387    12542     +155     
==========================================
+ Hits         9246     9452     +206     
+ Misses       3141     3090      -51     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@KvngMikey KvngMikey changed the title feat(core): new properties added to nut18 and nut26 payment request feat(core): Updates to nut18 and nut26 payment request Jun 21, 2026
@a1denvalu3

Copy link
Copy Markdown
Collaborator

@KvngMikey If I am not mistaken this only adds support for decoding such payment requests with the additional fields but does not add any logic to handle them or to create a payment request with them.

@KvngMikey

Copy link
Copy Markdown
Collaborator Author

@KvngMikey If I am not mistaken this only adds support for decoding such payment requests with the additional fields but does not add any logic to handle them or to create a payment request with them.

@a1denvalu3 you're right that this PR only adds encoding/decoding for the new ms / fr / sm fields and doesn't add enforcement logic.

Happy to either extend this PR with that handling + a request-creation path, or land this as the serialization layer and do the behavior in a focused follow-up. Which would you prefer?

@a1denvalu3

a1denvalu3 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Happy to either extend this PR with that handling + a request-creation path

Yes please

@robwoodgate

Copy link
Copy Markdown
Contributor

The nut has been updated: ms (mint_strict) is now flipped to mp (mint_preferred) to avoid the omitted=true antipattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

5 participants