Skip to content

feat(crypto): align NUT-20/29 signatures with spec change#1054

Merged
a1denvalu3 merged 1 commit into
cashubtc:mainfrom
a1denvalu3:fix/nut-29-batch-minting
Jun 18, 2026
Merged

feat(crypto): align NUT-20/29 signatures with spec change#1054
a1denvalu3 merged 1 commit into
cashubtc:mainfrom
a1denvalu3:fix/nut-29-batch-minting

Conversation

@a1denvalu3

Copy link
Copy Markdown
Collaborator

Aligns NUT-20/29 batch minting signatures to the spec changes in cashubtc/nuts pull request 375, while retaining fallback legacy signature verification for older wallets.

@a1denvalu3

Copy link
Copy Markdown
Collaborator Author

This aligns nutshell with the NUT-20/29 spec changes defined in: cashubtc/nuts#375

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.19%. Comparing base (71df49b) to head (86564db).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cashu/core/nuts/nut20.py 82.14% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
+ Coverage   75.15%   75.19%   +0.03%     
==========================================
  Files         111      111              
  Lines       12372    12395      +23     
==========================================
+ Hits         9298     9320      +22     
- Misses       3074     3075       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@a1denvalu3 a1denvalu3 merged commit eee256b into cashubtc:main Jun 18, 2026
54 of 58 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in nutshell Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant