test: drop unused MODEL_SETTINGS from tox environments and example charms - #2702
Open
sundeep8967 wants to merge 1 commit into
Open
test: drop unused MODEL_SETTINGS from tox environments and example charms#2702sundeep8967 wants to merge 1 commit into
sundeep8967 wants to merge 1 commit into
Conversation
Remove the unused MODEL_SETTINGS variable from passenv in root tox.ini and example charm tox configurations. MODEL_SETTINGS is not read by Jubilant or documented as a standard harness option, and was legacy placeholder configuration. Fixes canonicalGH-2652 Signed-off-by: sundeep8967 <sundeep8967@gmail.com>
tonyandrewmeyer
changed the title
tonyandrewmeyer
approved these changes
Aug 26, 2026
tonyandrewmeyer
left a comment
tonyandrewmeyer
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for contributing this. Seems fine to me. The odd passenv/pass_env difference will be handling when we move to Make. I've cleaned up the PR title and description - please try to match our style in any future contributions.
dwilding
approved these changes
Aug 26, 2026
dwilding
left a comment
dwilding
left a comment
Contributor
There was a problem hiding this comment.
Approved - thanks @sundeep8967!
But I would rather wait for the Charmcraft profiles update before merging this, otherwise our example charms will be (very slightly) out of sync with what our K8s tutorial produces.
@tonyandrewmeyer I will open a Charmcraft PR today to try to catch the next release along with our other pending profile changes.
Contributor
|
Charmcraft PR: canonical/charmcraft#2852 |
sundeep8967
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
tox.inifor the root workspace and example charms,MODEL_SETTINGSwas listed underpassenv/pass_env. This variable is not read by Jubilant or documented as a standard harness option, leaving an unused legacy placeholder across example charms.MODEL_SETTINGSfrompassenvin roottox.ini.MODEL_SETTINGSfrompass_envacross all 7 example charms (httpbin-demo,k8s-1-minimal,k8s-2-configurable,k8s-3-postgresql,k8s-4-action,k8s-5-observe, andmachine-tinyproxy).Refs #2652 - note that the charmcraft PR still needs to be done too.