Skip to content

fix: correct license check to use data.valid instead of data.status in API v2 #28521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Harshithk951 wants to merge 4 commits into from
+5 −3
Closed

fix: correct license check to use data.valid instead of data.status in API v2 #28521

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b7b329
fix: correct license check to use data.valid instead of data.status i…
Harshithk951 Mar 12, 2026
44fb2b2
fix: add fallback for cached license responses using data.status
Harshithk951 Mar 21, 2026
87b7bee
fix: update LicenseCheckResponse type to include both valid and statu…
Harshithk951 Mar 25, 2026
5078098
Merge branch 'main' into fix/license-check-valid-field-v2
Harshithk951 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions apps/api/v2/src/modules/deployments/deployments.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ const CACHING_TIME = 86400000; // 24 hours in milliseconds
const getLicenseCacheKey = (key: string) => `api-v2-license-key-goblin-url-${key}`;

type LicenseCheckResponse = {
status: boolean;
valid?: boolean;
status?: boolean;
};
@Injectable()
export class DeploymentsService {
Expand Down Expand Up @@ -36,12 +37,13 @@ export class DeploymentsService {
const licenseKeyUrl = this.configService.get("api.licenseKeyUrl") + `/${licenseKey}`;
const cachedData = await this.redisService.redis.get(getLicenseCacheKey(licenseKey));
if (cachedData) {
return (JSON.parse(cachedData) as LicenseCheckResponse)?.status;
const cached = JSON.parse(cachedData) as LicenseCheckResponse;
return cached.valid ?? cached.status ?? false;
}
const response = await fetch(licenseKeyUrl, { mode: "cors" });
const data = (await response.json()) as LicenseCheckResponse;
const cacheKey = getLicenseCacheKey(licenseKey);
this.redisService.redis.set(cacheKey, JSON.stringify(data), "EX", CACHING_TIME);
return data.status;
return data.valid ?? data.status ?? false;
}
}