Merged
Conversation
LordSimal
force-pushed
the
5.next-rector
branch
from
edb7360 to
acdcb21
Compare
LordSimal
force-pushed
the
5.next-rector
branch
from
acdcb21 to
fb60422
Compare
Contributor
Author
|
Refs: cakephp/.github#26 |
markstory
reviewed
Mar 22, 2026
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
The changes rector applied seem good to me. Would we be able to put rector.php into a package that we can share across plugins?
Contributor
Author
|
A shared (or at least baseline) rector config would be great, but we'd need to add it to something all projects depend on. The rector config is just a object with chainable config calls, so it would be just 1 additional require before the rector.php in each package using it. We could of course also just make an additional package/repo and add it as a dev dependency, but I don't know if this is the best way to go. |
markstory
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would be changed by rector if we added it to debug_kit. Would love to see this across all our plugins to get more consistency.
Woud be cool if we could somehow unify the rector config across repositories though.
The shared CI workflow also needs to be adjusted to execute rector (if its present)